fix(dav): allow moving files between subfolders of the same share - #64106
fix(dav): allow moving files between subfolders of the same share#64106Antreesy wants to merge 2 commits into
Conversation
- group folder storage doesn't implement ISharedStorage, so moves within the same team folder were rejected as cross-share moves. Compare the source's and target's enclosing shares directly instead. - add unit tests coverage in SharesPluginTest.php Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
I don't think this is a valid change. It allows moving files to a different share, which could lead to different permissions. For example if writing was not allowed by the source share but by any of the target shares, this would be a permission escalation.
I also don't see how this should work for groupfolders, because they are not shares. This fix only addresses it for shares, while the code comment says it is also supposed to work for groupfolders (which would have the same permission escalation issue).
So I'm blocking this for now.
It's about shares within groupfolders, not groupfolders themselves. Current code allows the same for user-owned files shares; groupfolders-owned files shares do not work only because they are not instance of ISharedStorage |
3 participants
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)