Skip to content

fix 4311 tests - #1001

Merged
zhindes merged 1 commit into
masterfrom
users/zhindes/fix_4311
Aug 3, 2026
Merged

fix 4311 tests#1001
zhindes merged 1 commit into
masterfrom
users/zhindes/fix_4311

Conversation

@zhindes

@zhindes zhindes commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator
  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Fixes tests that were added for the 4311 earlier this year.

  • Update CONTRIBUTING
  • Update 4311 PID from a no-longer supported prototype to the new PID
  • Disabled grpc on tests that do not work there - See Internal Bug 4000847: calculated power channel doesn't work over grpc in Python since it requires internal_get_last_created_chan.

Why should this Pull Request be merged?

Simple cleanup

What testing has been done?

Tests pass.

Comment thread tests/component/task/channels/test_ai_channel.py Outdated
Comment thread tests/component/task/channels/test_ai_channel.py Outdated
@zhindes
zhindes force-pushed the users/zhindes/fix_4311 branch from b902cdd to ce7c14f Compare August 3, 2026 19:02
@zhindes
zhindes requested a review from bkeryan August 3, 2026 19:02
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Test Results

    46 files  ±  0      46 suites  ±0   1h 16m 58s ⏱️ - 1m 37s
 3 173 tests  -  36   2 556 ✅ ±0     617 💤  -  36  0 ❌ ±0 
61 534 runs   - 432  49 136 ✅ ±0  12 398 💤  - 432  0 ❌ ±0 

Results for commit ce7c14f. ± Comparison against base commit e18602c.

This pull request removes 36 tests.
tests.component.task.channels.test_ai_channel ‑ test___task___add_ai_calculated_power_chan___sets_channel_attributes[grpc_init_kwargs-CurrentShuntResistorLocation.EXTERNAL-CurrentShuntResistorLocation.EXTERNAL-PowerUnits.FROM_CUSTOM_SCALE-power_scale--0.0015-0.0015--0.15-0.15]
tests.component.task.channels.test_ai_channel ‑ test___task___add_ai_calculated_power_chan___sets_channel_attributes[grpc_init_kwargs-CurrentShuntResistorLocation.EXTERNAL-CurrentShuntResistorLocation.EXTERNAL-PowerUnits.FROM_CUSTOM_SCALE-power_scale--0.0015-0.0015-0.0-25.0]
tests.component.task.channels.test_ai_channel ‑ test___task___add_ai_calculated_power_chan___sets_channel_attributes[grpc_init_kwargs-CurrentShuntResistorLocation.EXTERNAL-CurrentShuntResistorLocation.EXTERNAL-PowerUnits.FROM_CUSTOM_SCALE-power_scale--0.0015-0.0015-0.0-6.0]
tests.component.task.channels.test_ai_channel ‑ test___task___add_ai_calculated_power_chan___sets_channel_attributes[grpc_init_kwargs-CurrentShuntResistorLocation.EXTERNAL-CurrentShuntResistorLocation.EXTERNAL-PowerUnits.FROM_CUSTOM_SCALE-power_scale-0.0-0.06--0.15-0.15]
tests.component.task.channels.test_ai_channel ‑ test___task___add_ai_calculated_power_chan___sets_channel_attributes[grpc_init_kwargs-CurrentShuntResistorLocation.EXTERNAL-CurrentShuntResistorLocation.EXTERNAL-PowerUnits.FROM_CUSTOM_SCALE-power_scale-0.0-0.06-0.0-25.0]
tests.component.task.channels.test_ai_channel ‑ test___task___add_ai_calculated_power_chan___sets_channel_attributes[grpc_init_kwargs-CurrentShuntResistorLocation.EXTERNAL-CurrentShuntResistorLocation.EXTERNAL-PowerUnits.FROM_CUSTOM_SCALE-power_scale-0.0-0.06-0.0-6.0]
tests.component.task.channels.test_ai_channel ‑ test___task___add_ai_calculated_power_chan___sets_channel_attributes[grpc_init_kwargs-CurrentShuntResistorLocation.EXTERNAL-CurrentShuntResistorLocation.EXTERNAL-PowerUnits.FROM_CUSTOM_SCALE-power_scale-0.0-0.25--0.15-0.15]
tests.component.task.channels.test_ai_channel ‑ test___task___add_ai_calculated_power_chan___sets_channel_attributes[grpc_init_kwargs-CurrentShuntResistorLocation.EXTERNAL-CurrentShuntResistorLocation.EXTERNAL-PowerUnits.FROM_CUSTOM_SCALE-power_scale-0.0-0.25-0.0-25.0]
tests.component.task.channels.test_ai_channel ‑ test___task___add_ai_calculated_power_chan___sets_channel_attributes[grpc_init_kwargs-CurrentShuntResistorLocation.EXTERNAL-CurrentShuntResistorLocation.EXTERNAL-PowerUnits.FROM_CUSTOM_SCALE-power_scale-0.0-0.25-0.0-6.0]
tests.component.task.channels.test_ai_channel ‑ test___task___add_ai_calculated_power_chan___sets_channel_attributes[grpc_init_kwargs-CurrentShuntResistorLocation.EXTERNAL-CurrentShuntResistorLocation.EXTERNAL-PowerUnits.WATTS---0.0015-0.0015--0.15-0.15]
…

@zhindes
zhindes merged commit e1a3596 into master Aug 3, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants