Skip to content

nirfsa enum value fixed & changelog updated - #2238

Merged
vnktshr21 merged 3 commits into
ni:masterfrom
mohit-emerson:enum_changelog_update
Oct 23, 2026
Merged

vnktshr21 merged 3 commits into
ni:masterfrom
mohit-emerson:enum_changelog_update

Conversation

@mohit-emerson

@mohit-emerson mohit-emerson commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor
  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Revert enum values NONE_STR back to original NONE.
  • Changelog update of invalid None value removed from LoSource enum.

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

PR Validations

@codecov-commenter

codecov-commenter commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.12%. Comparing base (609c4ee) to head (b975c00).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2238   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          88       88           
  Lines       22830    22830           
=======================================
+ Hits        20118    20119    +1     
+ Misses       2712     2711    -1     
Flag Coverage Δ
codegenunittests 84.78% <ø> (ø)
nidcpowersystemtests 94.40% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.04% <ø> (ø)
nidigitalunittests 68.43% <ø> (ø)
nidmmsystemtests 92.33% <ø> (ø)
nifakeunittests 86.08% <ø> (ø)
nifgensystemtests 94.34% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests 82.71% <ø> (ø)
nirfsaunittests 63.37% <100.00%> (ø)
nirfsgsystemtests 81.22% <ø> (ø)
niscopesystemtests 89.99% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.66% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/nirfsa/metadata/enums.py Outdated
Comment thread CHANGELOG.md Outdated
@mohit-emerson mohit-emerson changed the title nirfsa Enum value fixed & changelog updated nirfsa enum value fixed & changelog updated Oct 23, 2026
@vnktshr21
vnktshr21 merged commit 2c18797 into ni:master Oct 23, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants