Fixing mod calculation to use fmod path#96
Open
SwayamInSync wants to merge 4 commits into
Open
Conversation
juntyr
approved these changes
May 16, 2026
Contributor
juntyr
left a comment
juntyr
left a comment
There was a problem hiding this comment.
LGTM with my nit addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #94
This PR updates the
modimplementation of both quad and longdouble backend to usefmodpath for high precision correctness.Note:
moddoes not dispatches the "signed" NaN values, as NumPy's fmod implementation using libc and which dispatches platform dependent NaN, whose sign has no relation with the divisor. (This is mention as a comment inside code)Anyways IEEE does not define any meaning to signed NaN values so we are just dispatching unsigned NaN