fix(lsp): treat files in any Flutter SDK as dependencies - #539
Merged
Merged
Conversation
Detect the SDK by its bin/flutter and bin/cache/dart-sdk markers instead of path fragments, so SDKs installed via mise, asdf, puro, etc. are read-only and reuse the project's dartls client. Resolve the root from the attached buffer rather than whichever buffer is current when the async config callback runs. Fixes #534
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/flutter+bin/cache/dart-sdkmarkers (same as Dart-Code) instead of only.pub-cache//fvm/versions/path fragments. SDKs installed via mise, asdf, puro, Homebrew, etc. are now read-only and reuse the project's dartls client instead of starting one rooted at the SDK (whosepubspec.yamlis a pub workspace root).attach()resolves the root from the buffer it was called for; withflutter_lookup_cmdthe config callback is async and previously used whichever buffer was current.Fixes #534