Thin the free step summary to a link; add workflow param; drop the notice#144
Merged
Merged
Conversation
…tice
Move the volatile free-review content off the (frozen, version-pinned) action
and onto the /review page we deploy. The breaking/changelog step summary is now
a single link to the page, which renders the command, install help, and any
upgrade nudge. Keeping that on the page means we can change it without shipping
a new action version that users must upgrade to (the missing-fetch command this
spring would have been a page-only fix).
- Step summary: one retitled link ("View these ... changes in a side-by-side
review"), no baked command, no "approve" framing (free can't approve in place).
- Drop the duplicate ::notice:: review link: it isn't clickable in GitHub
annotations and only repeated the summary; per-change ::error:: annotations
remain the inline CI signal.
- Add a `workflow` param from GITHUB_WORKFLOW_REF (the exact .github/workflows
file path), so the page can deep-link the file to bump the action pin. Older
links without it fall back to the workflows folder on the page side.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…om public entrypoints)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the volatile free-review content off the frozen, version-pinned action and onto the
/reviewpage we deploy. The lesson from the missing-git fetchbug this spring: anything baked into the action is stuck at whatever version a user pinned, so a fix has to be released and every user has to upgrade. Content on the page is fixed for everyone instantly.Changes (breaking + changelog free actions)
/reviewpage (retitled "View these … changes in a side-by-side review", dropping the "approve" framing free can't deliver). No baked command. The page renders the command, install help, and any upgrade nudge.::notice::review link. It isn't clickable in GitHub annotations and only duplicated the summary. The per-change::error::annotations remain the inline CI signal.workflowparam derived fromGITHUB_WORKFLOW_REF(the exact.github/workflows/<file>path), so the page can deep-link the workflow file to bump the action pin. Links from older actions that don't send it fall back to the.github/workflowsfolder (handled page-side).Compatibility
Pure additive on the URL (
&workflow=…); the page validates/ignores it and falls back gracefully. The Propr-commentaction and its notice are untouched.review_urloutput shape is unchanged except the appended param, so the existing URL-shape tests still hold.🤖 Generated with Claude Code