Skip to content

fix: Confirming twice when deploying ROFL - #723

Open
matevz wants to merge 1 commit into
masterfrom
matevz/fix/rofl-deploy-double-confirm
Open

matevz wants to merge 1 commit into
masterfrom
matevz/fix/rofl-deploy-double-confirm

Conversation

@matevz

@matevz matevz commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

When running oasis rofl deploy the CLI asked to unlock the account twice for no reason.

@matevz
matevz requested a review from kostko October 9, 2026 15:31
@netlify

netlify Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit 6517f7d
🔍 Latest deploy log https://app.netlify.com/projects/oasisprotocol-cli/deploys/6ac908eca11c550008fdb1df

Comment thread cmd/rofl/deploy.go
var acc wallet.Account
if !common.TxUnsigned {
acc = common.LoadAccount(cliConfig.Global(), npa.AccountName)
} else {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use a switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants