Repository navigation
fix(bridge): pass owner Peer to DSH 0.2.1 Gateway streams - #124
Open
zzalancelot wants to merge 4 commits into
Open
zzalancelot wants to merge 4 commits into
zzalancelot wants to merge 4 commits into
Conversation
DSH 0.2.1-rc.2 requires a live Peer on wireStream.open, invoke, and shared-fetch. Passing undefined made $events throw on peer.signal after hello.ok, closing the extension WebSocket with 1011 stream-failed.
HostConnectionLike now requires createPeer for DSH 0.2.1; update the extension typecheck fixture so CI passes.
Pending SelectionWatcher debounce callbacks were surviving afterEach vi.useRealTimers() and throwing document is not defined after jsdom teardown, which Vitest reported as unhandled errors.
Smoke and dsh 0.2.0-rc.2 Connection lack createPeer. Use it when present (0.2.1+), otherwise fall back to a local owner Peer stand-in so the plugin still activates.
zzalancelot
added a commit
to zzalancelot/dsh-browser
that referenced
this pull request
Oct 18, 2026
Bring DSH 0.2.1 Peer/stream fixes onto maintain alongside open-window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.2.1-rc.2requires a live Connection Peer onwireStream.open,invoke, and shared-fetch ($eventsneedsinteractions: answer).undefinedas peer, so$eventsthrew onpeer.signalright afterhello.okand closed the extension WebSocket with1011/stream-failed.connection.createPeer({ principal: { kind: "owner" }, interactions: "answer" })and pass it through stream / invoke / shared-fetch paths.Test plan
0.2.1-rc.2, open the extension side panel and confirm Connected stays up (no reconnect loop)stream-failedpnpm --filter @yuxianglin/dsh-bridge-browser test