Skip to content

Shorten the author reminder comment - #276

Merged
maryliag merged 3 commits into
mainfrom
trask-shorten-author-reminder
Aug 20, 2026
Merged

Shorten the author reminder comment#276
maryliag merged 3 commits into
mainfrom
trask-shorten-author-reminder

Conversation

@trask

@trask trask commented Aug 20, 2026

Copy link
Copy Markdown
Member

The author reminder comment was five paragraphs, and most of it explained the mechanism rather than telling the author what to do. It now leads with the link to the live status and gives two bullets: reply, or hand it back.

Hi @author — just a friendly reminder that this pull request is waiting on you. The [dashboard status comment](URL) has the open items and is kept current.

- Replying is enough to hand it off — answer, explain why no change is needed, or ask a follow-up. The dashboard routes it onward once nothing on the list is waiting on you.
- To hand it back for any other reason, including the dashboard getting this wrong, comment `/dashboard route:reviewers`.

The first bullet does not name where the pull request goes next, and does not promise that a reply alone moves it. Routing depends on approvals, so an already-approved pull request can go straight to maintainers, and a failing required check keeps the pull request with the author no matter what the author says.

The second bullet no longer justifies the command by the author needing reviewer help, because that framing left no room for the case where routing is simply wrong. Naming that case invites authors to use the command instead of arguing with the bot in prose.

Dropped: the snapshot footer, since the sentence above it already says the linked comment is kept current, and the explanation of how the command binds to the head it sees, which authors do not need in a reminder.

Already-posted reminders keep the old wording. Nothing rewrites an existing nudge body, and adding that is not worth the complexity for a one-time wording change.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@trask
trask requested a balanced review from Copilot August 20, 2026 15:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Shortens and clarifies the author reminder.

Changes:

  • Replaces the long reminder with two actionable bullets.
  • Updates tests and documentation for the revised wording.
  • Removes snapshot and command-binding explanations.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
pull-request-dashboard/README.md Documents the shorter reminder.
.github/scripts/pull-request-dashboard/test_author_nudge.py Updates reminder assertions.
.github/scripts/pull-request-dashboard/author_nudge.py Generates the revised reminder.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pull-request-dashboard/README.md
Comment thread .github/scripts/pull-request-dashboard/author_nudge.py Outdated
@trask
trask marked this pull request as ready for review August 20, 2026 15:25
@trask
trask requested a review from a team as a code owner August 20, 2026 15:25
@trask
trask requested a review from mx-psi August 20, 2026 15:25
@trask
trask marked this pull request as draft August 20, 2026 15:25
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@trask
trask requested a balanced review from Copilot August 20, 2026 15:32
@trask
trask marked this pull request as ready for review August 20, 2026 15:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (2)

pull-request-dashboard/README.md:244

  • “Replying” is broader than the documented behavior: a reply that commits to future work remains with the author (lines 124-130 and 151-165). Qualify this as a completed reply so this summary does not contradict the lifecycle rules above.
replying is enough to resume normal approval-based routing, and advertises

.github/scripts/pull-request-dashboard/author_nudge.py:329

  • This reminder is also posted while the author route is held by required checks or Copilot review (test_author_nudge.py:381-391), but those gates keep the route at author even after a review reply (dashboard.py:1567-1626), and failing checks force the author route independently (dashboard.py:1253-1255). In those cases replying does not hand off the pull request, so the reminder can remain active after the author follows this instruction. Please scope this bullet to clearing review items and say that onward routing waits for any other author-owned blockers; update the matching test assertion as well.
        "- Replying is enough to hand it off — answer, explain why no change is "
        "needed, or ask a follow-up. The dashboard routes it onward "
        "automatically.",

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 20, 2026

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-08-20 23:58 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@trask
trask requested a balanced review from Copilot August 20, 2026 16:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@maryliag
maryliag merged commit 8e4c4c8 into main Aug 20, 2026
7 checks passed
@maryliag
maryliag deleted the trask-shorten-author-reminder branch August 20, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants