Skip to content

Make Netlify queue mode updates repeatable - #277

Merged
trask merged 1 commit into
mainfrom
trask-fix-netlify-queue-mode
Aug 21, 2026
Merged

Make Netlify queue mode updates repeatable#277
trask merged 1 commit into
mainfrom
trask-fix-netlify-queue-mode

Conversation

@trask

@trask trask commented Aug 20, 2026

Copy link
Copy Markdown
Member

Prevents dashboard promotions from failing when PR_DASHBOARD_QUEUE_MODE already exists in Netlify.

The deployment now removes the existing variable before recreating it with production function scope. This matches the recovery used for the v0.9.0 rollout and keeps later canary-to-all transitions automatic.

Unset the existing queue mode before recreating it with production function scope.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 94db1c6d-c054-464e-8b19-b6c448fef95f
@trask
trask requested a balanced review from Copilot August 20, 2026 15:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Makes Netlify queue-mode promotions repeatable by removing the existing variable before recreating it with the required production function scope.

Changes:

  • Unsets PR_DASHBOARD_QUEUE_MODE before setting it.
  • Tests that removal occurs before recreation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/pull-request-dashboard-deploy-webhook.yml Adds the pre-update environment-variable removal.
.github/scripts/pull-request-dashboard/test_rollout.py Verifies the required update ordering.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@trask
trask marked this pull request as ready for review August 20, 2026 15:34
@trask
trask requested a review from a team as a code owner August 20, 2026 15:34
@trask
trask requested a review from adrielp August 20, 2026 15:34
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 20, 2026

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-08-21 01:01 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@trask
trask merged commit abcfad2 into main Aug 21, 2026
7 checks passed
@trask
trask deleted the trask-fix-netlify-queue-mode branch August 21, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants