Skip to content

Load dashboard code from the reusable workflow commit - #285

Merged
trask merged 2 commits into
mainfrom
trask-fix-dashboard-cache-alerts
Aug 21, 2026
Merged

Load dashboard code from the reusable workflow commit#285
trask merged 2 commits into
mainfrom
trask-fix-dashboard-cache-alerts

Conversation

@trask

@trask trask commented Aug 21, 2026

Copy link
Copy Markdown
Member

Resolves code-scanning alerts #46 and #47 by loading pull request dashboard scripts through GitHub's self-repository action syntax. The workflow and scripts now always come from the same immutable commit without a caller-controlled checkout.

  • Keeps code_ref as an ignored compatibility input until the first release containing this change is promoted, so callers pinned to v0.10.0 retain their existing behavior. #286 tracks removing this compatibility wiring after promotion.
  • Preserves live configuration from the triggering commit and the existing staged rollout and promotion process.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 1eab96b0-ec5b-48cf-9098-3645427d7358
Comment thread .github/workflows/pull-request-dashboard-repo.yml Fixed
Comment thread .github/workflows/pull-request-dashboard-repo.yml Fixed
Comment thread .github/workflows/pull-request-dashboard-repo.yml Fixed
Comment thread .github/workflows/pull-request-dashboard-repo.yml Fixed
Comment thread .github/workflows/pull-request-dashboard-repo.yml Fixed
Comment thread .github/workflows/pull-request-dashboard-repo.yml Fixed
Comment thread .github/workflows/pull-request-dashboard-repo.yml Fixed
Comment thread .github/workflows/pull-request-dashboard-repo.yml Fixed
Comment thread .github/workflows/pull-request-dashboard-repo.yml Fixed
Comment thread .github/workflows/pull-request-dashboard-repo.yml Fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Uses GitHub Actions self-repository syntax to securely load dashboard scripts from the reusable workflow’s immutable commit.

Changes:

  • Replaces caller-controlled script checkout with a self-repository composite action.
  • Updates script and cache paths to use the action output.
  • Updates rollout tests and documentation for compatibility behavior.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/pull-request-dashboard.yml Documents transitional rollout behavior.
.github/workflows/pull-request-dashboard-repo.yml Loads and executes commit-matched dashboard code.
.github/scripts/pull-request-dashboard/test_rollout.py Verifies self-repository workflow wiring.
.github/scripts/pull-request-dashboard/test_promote_rollout.py Updates promotion-test terminology.
.github/scripts/pull-request-dashboard/RATIONALE.md Documents the new security model.
.github/scripts/pull-request-dashboard/action.yml Exposes the immutable dashboard-code path.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 1eab96b0-ec5b-48cf-9098-3645427d7358
@trask
trask requested a balanced review from Copilot August 21, 2026 02:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

@trask
trask marked this pull request as ready for review August 21, 2026 02:36
@trask
trask requested a review from a team as a code owner August 21, 2026 02:36
@trask
trask requested a review from mx-psi August 21, 2026 02:36
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 21, 2026

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-08-21 14:33 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@trask
trask merged commit 5298763 into main Aug 21, 2026
7 checks passed
@trask
trask deleted the trask-fix-dashboard-cache-alerts branch August 21, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants