Skip to content

Defer locked terminal dashboard comments - #291

Open
trask wants to merge 1 commit into
mainfrom
trask-avoid-locked-pr-failures
Open

Defer locked terminal dashboard comments#291
trask wants to merge 1 commit into
mainfrom
trask-avoid-locked-pr-failures

Conversation

@trask

@trask trask commented Aug 21, 2026

Copy link
Copy Markdown
Member

Defers updates to existing dashboard status comments while terminal pull requests are locked, preserving them in the rollout queue for a later retry instead of failing delivery.

Locked terminal pull requests without an existing status comment remain no-ops, so the dashboard does not create unnecessary retry work.

Addresses the transient failure reported in #290.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 564632a8-976e-4a20-a7a0-c7dd01f075c9

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prevents dashboard delivery failures from locked terminal pull requests by deferring existing comment updates for later retry.

Changes:

  • Adds explicit deferred-status handling for locked terminal pull requests.
  • Preserves deferred updates in the rollout queue without reporting delivery errors.
  • Adds coverage for locked comments and rollout behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/scripts/pull-request-dashboard/pr_status_comment.py Detects and retains deferred locked-comment updates.
.github/scripts/pull-request-dashboard/test_pr_status_comment.py Tests locked terminal and deferred rollout scenarios.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@trask
trask marked this pull request as ready for review August 21, 2026 17:51
@trask
trask requested a review from a team as a code owner August 21, 2026 17:51
@trask
trask requested a review from mx-psi August 21, 2026 17:51
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 21, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on maintainers · refreshed 2026-08-21 22:06 UTC

Merge when ready.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants