Create dedicated Storybook section on website for interactive editor exploration - #18
Conversation
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
✅ Deploy Preview for openworkflow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| </div> | ||
| <div class="navbar-end"> | ||
| <ul class="menu menu-horizontal px-1"> | ||
| <li><a href="https://openworkflow-editor.netlify.app/" target="_blank">Playground</a></li> |
There was a problem hiding this comment.
Should move this link to the consts.ts file where other external links are for consistency. And lets also add rel="noopener" as all external links on this site have it as well
There was a problem hiding this comment.
Also wondering should we change from Playground > Try the Editor
wdyt?
| <script> | ||
| document.addEventListener("DOMContentLoaded", () => { | ||
| const popup = document.getElementById("editor-popup"); | ||
| const closeButton = document.getElementById("editor-popup-close"); |
There was a problem hiding this comment.
Because this isnt persisted to session or local storage, it means you can close pop, then if you navigate to Blog or something else and come back it will reappear
@ricardozanini @JBBianchi Would you prefer if when you dismiss the pop up, you dont have to dismiss again or you are ok with the above behaviour
There was a problem hiding this comment.
I'm ok with the popup showing all the time :D
| </div> | ||
| <div class="navbar-end"> | ||
| <ul class="menu menu-horizontal px-1"> | ||
| <li><a href="https://openworkflow-editor.netlify.app/" target="_blank">Playground</a></li> |
There was a problem hiding this comment.
@lornakelly https://openworkflow-editor.netlify.app/ is the deployment from main branch, which is ok for now and it's updated.
I think for the Editor, as a next step, we should have a deployment
- from the version tag (ie.
1.1.0) - possibly using GH Pages as Netlify deletes a deployment after a while ( default should be 90days)
Does it make sense?
There was a problem hiding this comment.
Yes most definitely, good catch - otherwise they are going to see features not released yet. Can you please add a ticket to the editor repo for his @fantonangeli ?
There was a problem hiding this comment.
Yes, I agree -> we will need a new netlify account perhaps?
There was a problem hiding this comment.
@ricardozanini I’ve also done some research on this topic. Netlify deploy are subject to retention, so permanent versioned release URLs would require additional setup, likely a dedicated release site managed from our release CI, and not fully automated by Netlify..
GitHub Pages seems simpler for this use case: we can publish releases directly from the release workflow and naturally expose permanent versioned URLs such as /1.1.0/, /1.2.0/, etc, and we can always view a previous version.
There was a problem hiding this comment.
Wow, we could publish directly to the org's GH page and we would have an /editor path.
There was a problem hiding this comment.
If we create a GH Pages under https://github.com/open-workflow-specification/editor we can manage autonomously, and @lornakelly already has permissions for that
There was a problem hiding this comment.
Issue created: open-workflow-specification/editor#387
|
@lornakelly @fantonangeli are we ready to merge this? |
5 participants
Closes #9
Changes
Screenshot