Merged
Conversation
e57368a to
6e690ad
Compare
6e690ad to
c68f062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release readiness review (v0.14.1 -> TARGET c68f062)
This is a release readiness report done by
$final-release-reviewskill.Diff
v0.14.1...c68f062
Release call:
🟢 GREEN LIGHT TO SHIP No concrete release-blocking regression or compatibility break is evidenced in
v0.14.1...c68f062d70be5ffaa7054f34b229d9d4a51b989a.Scope summary:
src/agents/sandbox/**,tests/sandbox/**), run-loop/tool metadata persistence (src/agents/run_internal/**,src/agents/items.py,src/agents/run_state.py,tests/test_tool_origin.py), new MongoDB memory backend (src/agents/extensions/memory/mongodb_session.py,tests/extensions/memory/test_mongodb_session.py), model/provider fixes (src/agents/models/openai_chatcompletions.py,src/agents/extensions/models/litellm_model.py), docs/translations, and version bump to0.14.2.Risk assessment (ordered by impact):
Sandbox path-grant confinement changes are broad and security-sensitive
src/agents/sandbox/workspace_paths.py,src/agents/sandbox/session/base_sandbox_session.py, andsrc/agents/sandbox/sandboxes/unix_local.py, including new extra grant semantics and write-deny handling (WorkspaceArchiveWriteErrorpaths, new helper exit-code handling).src/agents/sandbox/workspace_paths.py,src/agents/sandbox/session/base_sandbox_session.py,src/agents/sandbox/sandboxes/unix_local.py,tests/sandbox/test_workspace_paths.py,tests/sandbox/test_runtime.py,tests/sandbox/test_docker.pyuv run pytest -q tests/sandbox/test_workspace_paths.py tests/sandbox/test_runtime.py tests/sandbox/test_docker.py -k "extra_path_grant or validate_remote_path_access or normalize_path"; pass criteria: all selected tests pass with no new permission-escape failures.Run-item/tool-origin persistence touched streaming, approvals, and state serialization
ToolOrigin/ToolOriginTypewired through model response processing, approvals, generated items, and RunState serialization/deserialization; explicit tests added including legacy schema roundtrip behavior.src/agents/tool.py,src/agents/items.py,src/agents/run_internal/tool_execution.py,src/agents/run_internal/turn_resolution.py,src/agents/run_state.py,tests/test_tool_origin.pyuv run pytest -q tests/test_tool_origin.py tests/test_cancel_streaming.py tests/test_items_helpers.py; pass criteria: all tests pass, especially legacy schema and streamed exception assertions.Temporal sandbox example now depends on upstream
temporalioplugin instead of vendored patchtemporalio==1.26.0; example imports now assumetemporalio.contrib.openai_agentsis present.examples/sandbox/extensions/temporal/_vendored_plugin/*(deleted),examples/sandbox/extensions/temporal/justfile,examples/sandbox/extensions/temporal/temporal_sandbox_agent.py,pyproject.tomluv run --extra temporal --extra daytona --extra e2b --extra docker python examples/sandbox/extensions/temporal/temporal_sandbox_agent.py --help; pass criteria: command exits successfully without import errors.Notes:
v0.14.1.c68f062d70be5ffaa7054f34b229d9d4a51b989a.git status --shortproduced no output).