fix: prepare Daytona workspace root before start#2956
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes Daytona sandbox startup when the default
/home/daytona/workspacedirectory does not already exist. The modified_prepare_workspace_root()is internally called instart()method.The Daytona session now prepares the manifest workspace root through the provider process API before runtime helper installation or other SDK exec paths use that root as
cwd. This prevents startup from failing with acd: no such file or directoryerror on fresh Daytona sandboxes.The tests add a fake Daytona condition that reproduces the missing-root failure and verifies both successful root preparation and
WorkspaceStartErrorhandling when preparation fails.