ci: stop required checks from skipping when locks fail - #3756
Open
lazerg wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
lint,build,testandtest-httpx2declareneeds: dependency-locks, so a failing lock check skips all four. Themainruleset requires those checks but notdependency lock freshness, and GitHub counts a skipped required check as satisfied, solint,buildandtest (HTTPX2)stop gating in the one run where the lockfile is known to be wrong. The two matrix contexts differ: a skipped matrix job reports once under the unexpanded name, sotest (Python 3.10)andtest (Python 3.14)never report and the queue waits them out instead.The four jobs now run with
!cancelled()and fail on their first step whendependency-locksdid not succeed. That step runs beforeactions/checkout, so nothing from an unverified lockfile is fetched, installed or executed, and the required checks report red instead of disappearing. Same-repo pull requests still skip by design, and the merge queue still does the real run.test_required_checks_fail_when_dependency_provenance_failspins the guard next to the existing workflow assertions intests/test_uv_workflows.py, which already infer reachability fromneeds. I also ran it on a fork with a staleuv.lock:lint,buildand bothtestlegs failed atRequire fresh dependency lockswith every later step skipped.Additional context & links
Fixes #3755
Adding
dependency lock freshnessto the required checks would close the same hole without a workflow change, if you would rather do it there. A composite action would have avoided the repetition, but a local action only loads afteractions/checkout, which is what the guard has to run before.