Skip to content

MAC address for the access point name is in reversed byte order #315

Open

Description

@SubOptimal

@Tutmanichtun reported following issue openbikesensor/openbikesensor.github.io#161

"SSID ist die MAC-Adresse des Gerätes OpenBikeSensor-xxxxxxxxxxxx."
...
Zur Erzeugung der SSID wird von der MAC-Adresse 1 abgezogen, die einzelnen MAC-Blöcke Gruppenweise gespiegelt und Nullen am Anfang weggelassen. Zwei Beispiele:
| WiFi-SSID | MAC |
| OpenBikeSensor-378B25BF58 | 58:BF:25:8B:37:01 |
| OpenBikeSensor-E040A71AD6B8 | B8:D6:1A:A7:40:E1 |

Activity

  1. added a commit that references this issue on Sep 8, 2022
    34bf39e
  2. self-assigned this
    on Sep 10, 2022
  3. SubOptimal commented on Sep 10, 2022

    @SubOptimal
    MemberAuthor

    @amandel According to the documentation [1] the SoftAP MAC is +1 to the base MAC (which is returned by ESP.getEfuseMac()). Which would be the valid case for the OpenBikeSensor.

    The question which arise is. Should the SSID of the ConfigServer access point contain the base MAC or the SoftAP MAC?

    Using the base MAC would have the benefit that it could be queried for the board easily by esptool.py read_mac.

    What would be your opinion?

    If we go for the SoftAP MAC a possible solution can be seen on [2].

    [1] https://espressif-docs.readthedocs-hosted.com/projects/esp-idf/en/stable/api-reference/system/system.html#mac-address
    [2] SubOptimal@d04b6f7

  4. amandel commented on Sep 12, 2022

    @amandel
    Member

    Getting the mac address of a network device should be an easy task for the people needing it. Using the ESP.getEfuseMac() or a part of it in the SSID, was an approach to get a unique SSID even, if there are multiple OpenBikeSensors around. It was not meant to expose the MAC via the SSID as the documentation suggested. This then lead to openbikesensor/openbikesensor.github.io#161.

    I'm fine to change this as in your PR, we might ask in a Monday meeting or here if changing the SSID will cause problems. Assuming the hot spot mode is only used in initial setup (not via https://install.openbikesensor.org/), this should not affect many users.

    #141 is related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions