Add support for creating permission invites (shares) to mail addressses - #3440
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
🟢 Coverage 55.48% diff coverage
Metric Results Coverage variation Report missing for 071d8591 Diff coverage ✅ 55.48% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (071d859) Report Missing Report Missing Report Missing Head commit (8f1fdf7) 88741 21470 24.19% Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3440) 146 81 55.48% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
0984c08 to
879f134
Compare
|
@rhafer reva PR with permissions check should be merged first, then I will bump reva version and will do another rebase |
@maki5 Let's please try to get this one merged first. The reva change is pretty much independent and as the feature is disabled by default we can add the permission check as a follow up. To keeps this small and make the review easier I'd suggest the following:
|
9f54c59 to
efc540f
Compare
rhafer
left a comment
There was a problem hiding this comment.
A few, minor remarks. Good idea to enhance existing recipient validator!
…f recipient type in invite creation
efc540f to
312589f
Compare
aduffeck
left a comment
There was a problem hiding this comment.
lgtm besides the one nitpick
| lgIdentity := libregraph.Identity{ | ||
| Id: libregraph.PtrString(cs3UserID.GetOpaqueId()), | ||
| LibreGraphUserType: libregraph.PtrString(identity.UserTypeGuest), | ||
| } | ||
| lgIdentity.SetDisplayName(cs3UserID.GetOpaqueId()) | ||
| lgIdentity.SetLibreGraphUserType(identity.UserTypeGuest) |
There was a problem hiding this comment.
| lgIdentity := libregraph.Identity{ | |
| Id: libregraph.PtrString(cs3UserID.GetOpaqueId()), | |
| LibreGraphUserType: libregraph.PtrString(identity.UserTypeGuest), | |
| } | |
| lgIdentity.SetDisplayName(cs3UserID.GetOpaqueId()) | |
| lgIdentity.SetLibreGraphUserType(identity.UserTypeGuest) | |
| lgIdentity := libregraph.Identity{ | |
| Id: libregraph.PtrString(cs3UserID.GetOpaqueId()), | |
| DisplayName: cs3UserID.GetOpaqueId(), | |
| LibreGraphUserType: libregraph.PtrString(identity.UserTypeGuest), | |
| } |
This is reviving #2717, rebased and adapted to the changes we did to the reva APIs since then.
There is still some stuff left to do:
emailproperty of theDriveRecipientinstead of usingobjectIdand@libregraphibre.graph.recipient.type=mail. (As suggested in: Add support for mail grantees #2717 (review))The
httpyacfor the original PR is still supposed to work: