[SAI] Add SAI_IPMC_GROUP_ATTR_LABEL and SAI_NEXT_HOP_GROUP_ATTR_LABEL.#2283
Open
ksravani-hcl wants to merge 1 commit into
Open
[SAI] Add SAI_IPMC_GROUP_ATTR_LABEL and SAI_NEXT_HOP_GROUP_ATTR_LABEL.#2283ksravani-hcl wants to merge 1 commit into
ksravani-hcl wants to merge 1 commit into
Conversation
|
@vivekmoorthy Please review |
Contributor
|
LGTM. |
kcudnik
approved these changes
May 7, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tjchadaga
requested changes
May 19, 2026
Collaborator
|
you will need to refactor, rebase to master and force push |
Signed-off-by: SRAVANI KANASANI <kanasanis@google.com>
ksravani-hcl
force-pushed
the
label_update
branch
from
dbb6d19 to
64e1de4
Compare
Author
|
Author
|
@tjchadaga, Could you please review the PR and help to merge. |
kcudnik
approved these changes
Jun 18, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
@tjchadaga, Can you please review the changes and approve the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Introduce unique label attributes to IPMC groups, L2MC groups, and Next Hop objects:
This PR adds SAI_IPMC_GROUP_ATTR_LABEL, SAI_L2MC_GROUP_ATTR_LABEL, and SAI_NEXT_HOP_ATTR_LABEL as string-type attributes across their respective headers. These new attributes are defined with CREATE_AND_SET flags and a default empty string to enable unique identification and improved management of these resources.
what i did:
Added a LABEL attribute to IPMC groups, L2MC groups, and Next Hop objects.
why i did:
To allow unique string-based identification and easier tracking of these resources.