Optimized Forwarding Header#2297
Conversation
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
| SAI_NATIVE_HASH_FIELD_RDMA_BTH_DEST_QP = 0x00000023, | ||
|
|
||
| /** Native hash field RDMA packet BTH destination queue pair */ | ||
| SAI_NATIVE_HASH_FIELD_OFH_FLOW_LABEL = 0x00000024, |
There was a problem hiding this comment.
Fix the comments cut and paste error.
| * @flags CREATE_ONLY | ||
| * @default false | ||
| */ | ||
| SAI_ACL_TABLE_ATTR_FIELD_ACL_OFH_TYPE = SAI_ACL_TABLE_ATTR_FIELD_START + 0x167, |
There was a problem hiding this comment.
Please add match for version field
|
It will be good to draw an abstract SAI pipeline to illustrate the forwarding model of OFH in the documentation. |
| * @default false | ||
| */ | ||
| SAI_ACL_TABLE_ATTR_FIELD_OFH_COS = SAI_ACL_TABLE_ATTR_FIELD_START + 0x168, | ||
|
|
There was a problem hiding this comment.
Please add TTL decrement for action as well as match on TTL
| * @brief End of Rule Actions | ||
| */ | ||
| SAI_ACL_ENTRY_ATTR_ACTION_END = SAI_ACL_ENTRY_ATTR_ACTION_TAM_OBJECT, | ||
| SAI_ACL_ENTRY_ATTR_ACTION_END = SAI_ACL_ENTRY_ATTR_ACTION_SET_OFH_COS, |
There was a problem hiding this comment.
SAI_ACL_ACTION_TYPE_SET_ECN = 0x00000017,
Set ECN also supported for normal IP packet.
| /** | ||
| * @brief OFH header max size | ||
| * | ||
| * @type sai_int8_t |
| * | ||
| * @type bool | ||
| * @flags CREATE_AND_SET | ||
| * @default true |
There was a problem hiding this comment.
Should this be false by default?
|
|
||
| SAI_OFH_ADDR_FAMILY_AFH, | ||
|
|
||
| SAI_OFH_ADDR_FAMILY_UFH, |
|
|
||
| /** @validonly meta->attrvaluetype == SAI_ATTR_VALUE_TYPE_UINT64_RANGE_LIST */ | ||
| sai_u64_range_list_t u64rangelist; | ||
|
|
There was a problem hiding this comment.
Should the corresponding sai_ofh_addr_and_mask_t to SAI_ATTR_VALUE_TYPE_OFH_ADDR_AND_MASK type be added here?
| /** | ||
| * @brief Set OFH attribute value(s). | ||
| * | ||
| * @param[in] ofh_id TAM id |
| * @param[out] object_statuses List of status for every object. Caller needs to | ||
| * allocate the buffer | ||
| * | ||
| * @return #SAI_STATUS_SUCCESS on success when all objects are removed or |
There was a problem hiding this comment.
#SAI_STATUS_SUCCESS on success when all objects are set. Similarly for SAI_STATUS_FAILURE.
| * @param[out] object_statuses List of status for every object. Caller needs to | ||
| * allocate the buffer | ||
| * | ||
| * @return #SAI_STATUS_SUCCESS on success when all objects are removed or |
There was a problem hiding this comment.
#SAI_STATUS_SUCCESS on success when all objects are get/retrived. Similarly for SAI_STATUS_FAILURE.
| } sai_ofh_route_entry_attr_t; | ||
|
|
||
| /** | ||
| * @brief Unicast route entry |
There was a problem hiding this comment.
Please consider to add/change to OFH route entry.
| * | ||
| * @type sai_uint8_t | ||
| * @flags CREATE_AND_SET | ||
| * @default 6 |
There was a problem hiding this comment.
while other *_WIDTH fields are default to '0', This seems to be special.
4 participants
New PR is opened.
Old one where most of the review comments are there is closed
#2285