Packet Drop Monitoring#2298
Open
JaiOCP wants to merge 1 commit into
Open
Conversation
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
Closed
kcudnik
reviewed
Jun 22, 2026
| * | ||
| * @objects SAI_OBJECT_TYPE_TAM_EVENT_LEARN_ENTRY | ||
| */ | ||
| sai_object_id_t le_id; |
Collaborator
There was a problem hiding this comment.
does it make sense to make this object first in the structure?
Contributor
Author
There was a problem hiding this comment.
The attributes need a reference to the object hence I have kept it here in structure.
Any other suggestions?
Collaborator
There was a problem hiding this comment.
im just saying make it first field
Contributor
Author
There was a problem hiding this comment.
Just for curiosity. How does it help.
Alignment ??
Collaborator
There was a problem hiding this comment.
it does not change alignement, just from order perspective it make sense to have object id first and then it;s attributes, for example the same idea is when you create object or call set api, object id is first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces packet drop monitoring where monitoring can be enabled for a specific set of drop reasons for a specific stage of pipeline like ingress, egress and buffer. If this is done with hw learning enabled for deduplcation then this form packet drop monitoring is considered stateful.
This PR introduces framework for both stateful and stateless packet drop monitoring.
Accidentally closed PR
#2290