Repository navigation
chore(deps): bump PatternFly to 6.6.1 and react-intl to 10.1.25 - #285
Conversation
Align dependency versions across web-console and shared UI packages.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Amber reviewStatus: Failed The review stopped at 2026-09-15T19:53:09Z. A later job can retry this commit. |
amber-review-bot
left a comment
There was a problem hiding this comment.
Verdict
APPROVE. This is a clean, low-risk UI dependency alignment that bumps @patternfly/react-core/react-icons/react-table from 6.6.0 to 6.6.1 and react-intl from 10.1.18 to 10.1.25 across the web console and both shared UI packages, with a matching pnpm-lock.yaml. The change is internally consistent and touches no Go, security, or reconciliation surface.
What I verified
- Version consistency across the stack. All
package.jsonspecifiers (components/web-console,packages/gateway-management-ui,packages/operational-dashboard-ui, acrossdependencies,peerDependencies, anddevDependencies) now pin6.6.1/10.1.25. No stale6.6.0PatternFly or10.1.18react-intl references remain in anypackage.json. - Lockfile coherence.
pnpm-lock.yamldrops the now-orphaned@patternfly/react-styles@6.6.0and@patternfly/react-tokens@6.6.0entries (only6.6.1remains), and cascades the transitivereact-intlbump (@formatjs/intl4.1.17 -> 4.1.20,@formatjs/icu-messageformat-parser3.5.15 -> 3.5.17,intl-messageformat11.2.12 -> 11.2.14). The remaining6.6.0matches in the lockfile are unrelated (light-my-request@6.6.0,react: '>=16.6.0'peer ranges). - Blast radius. Peer consumers such as
@patternfly/widgetized-dashboard@1.0.0-prerelease.6are repointed to6.6.1in the lockfile, so peer resolution stays satisfied.
Non-blocking note
- These are patch/minor bumps; the PatternFly 6.6.x line is a patch series and react-intl 10.1.x is a patch series, so no API breakage is expected. Rely on the CI lockfile-sync and UI build/check steps (
pnpm --filter ... check) as the source of truth thatpnpm-lock.yamlis fully in sync; this cannot be fully validated from the diff alone. Confidence: High.
Cross-PR coordination
This PR is a deliberate consolidation of several outstanding automated dependency bumps that target the exact same versions and files. The individual bot PRs raising @patternfly/react-core to 6.6.1, @patternfly/react-icons to 6.6.1, @patternfly/react-table to 6.6.1, and react-intl to 10.1.25 (#188, #189, #225, #226) each perform a strict subset of the changes here against packages/gateway-management-ui/package.json and packages/operational-dashboard-ui/package.json. These are duplicate solutions to the same goal: only one path should land. Maintainers should decide to merge this combined PR and close #188, #189, #225, and #226 (or the reverse), rather than merging both, to avoid redundant lockfile churn and re-open/conflict cycles noted in the PR description.
Previous concerns
No prior Amber findings exist for this pull request; the review history is empty.
Findings Summary (ordered by severity, highest first):
No blocking, critical, or major findings.
- [Minor] Lockfile full-sync can only be confirmed by CI, not the diff - Observability / Build hygiene (pnpm-lock.yaml)
Convention Checklist (only conventions applicable to this diff):
| Convention | Result |
|---|---|
| Image/version references consistent across the stack | Pass |
| Conventional commit message | Pass |
| No secrets in changed files | Pass |
| PostgreSQL / reconcile / SecurityContext rules | N/A (no backend or manifest changes) |
|
lgtm |
Align dependency versions across web-console and shared UI packages. Co-authored-by: jsell-rh <jsell@redhat.com>
Align dependency versions across web-console and shared UI packages.
This combines the fixes that were attempted in PRs: #188 , #189 , #225 , and #256
For what ever reason, the lock file was updated and committed in those PRs causing failures.
Details:
6.6.0→6.6.16.6.0→6.6.16.6.0→6.6.110.1.18→10.1.25