Skip to content

chore(deps): bump PatternFly to 6.6.1 and react-intl to 10.1.25 - #285

Merged
jsell-rh merged 2 commits into
openshift-online:mainfrom
kdoberst:Fix-node-modules-update
Sep 15, 2026
Merged

jsell-rh merged 2 commits into
openshift-online:mainfrom
kdoberst:Fix-node-modules-update

Conversation

@kdoberst

Copy link
Copy Markdown
Collaborator

Align dependency versions across web-console and shared UI packages.

This combines the fixes that were attempted in PRs: #188 , #189 , #225 , and #256

For what ever reason, the lock file was updated and committed in those PRs causing failures.

Details:

Package Change Age Confidence
@patternfly/react-core 6.6.0 → 6.6.1 age confidence
@patternfly/react-icons 6.6.0 → 6.6.1 age confidence
@patternfly/react-table (source) 6.6.0 → 6.6.1 age confidence
react-intl (source) 10.1.18 → 10.1.25 age confidence

Align dependency versions across web-console and shared UI packages.
@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: ccb7e8b6-1906-45a9-9509-f1d9d0190c84

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@amber-review-bot

amber-review-bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Collaborator

Amber review

Status: Failed

The review stopped at 2026-09-15T19:53:09Z. A later job can retry this commit.

@amber-review-bot amber-review-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict

APPROVE. This is a clean, low-risk UI dependency alignment that bumps @patternfly/react-core/react-icons/react-table from 6.6.0 to 6.6.1 and react-intl from 10.1.18 to 10.1.25 across the web console and both shared UI packages, with a matching pnpm-lock.yaml. The change is internally consistent and touches no Go, security, or reconciliation surface.

What I verified

  • Version consistency across the stack. All package.json specifiers (components/web-console, packages/gateway-management-ui, packages/operational-dashboard-ui, across dependencies, peerDependencies, and devDependencies) now pin 6.6.1 / 10.1.25. No stale 6.6.0 PatternFly or 10.1.18 react-intl references remain in any package.json.
  • Lockfile coherence. pnpm-lock.yaml drops the now-orphaned @patternfly/react-styles@6.6.0 and @patternfly/react-tokens@6.6.0 entries (only 6.6.1 remains), and cascades the transitive react-intl bump (@formatjs/intl 4.1.17 -> 4.1.20, @formatjs/icu-messageformat-parser 3.5.15 -> 3.5.17, intl-messageformat 11.2.12 -> 11.2.14). The remaining 6.6.0 matches in the lockfile are unrelated (light-my-request@6.6.0, react: '>=16.6.0' peer ranges).
  • Blast radius. Peer consumers such as @patternfly/widgetized-dashboard@1.0.0-prerelease.6 are repointed to 6.6.1 in the lockfile, so peer resolution stays satisfied.

Non-blocking note

  • These are patch/minor bumps; the PatternFly 6.6.x line is a patch series and react-intl 10.1.x is a patch series, so no API breakage is expected. Rely on the CI lockfile-sync and UI build/check steps (pnpm --filter ... check) as the source of truth that pnpm-lock.yaml is fully in sync; this cannot be fully validated from the diff alone. Confidence: High.

Cross-PR coordination

This PR is a deliberate consolidation of several outstanding automated dependency bumps that target the exact same versions and files. The individual bot PRs raising @patternfly/react-core to 6.6.1, @patternfly/react-icons to 6.6.1, @patternfly/react-table to 6.6.1, and react-intl to 10.1.25 (#188, #189, #225, #226) each perform a strict subset of the changes here against packages/gateway-management-ui/package.json and packages/operational-dashboard-ui/package.json. These are duplicate solutions to the same goal: only one path should land. Maintainers should decide to merge this combined PR and close #188, #189, #225, and #226 (or the reverse), rather than merging both, to avoid redundant lockfile churn and re-open/conflict cycles noted in the PR description.

Previous concerns

No prior Amber findings exist for this pull request; the review history is empty.

Findings Summary (ordered by severity, highest first):

No blocking, critical, or major findings.

  1. [Minor] Lockfile full-sync can only be confirmed by CI, not the diff - Observability / Build hygiene (pnpm-lock.yaml)

Convention Checklist (only conventions applicable to this diff):

Convention Result
Image/version references consistent across the stack Pass
Conventional commit message Pass
No secrets in changed files Pass
PostgreSQL / reconcile / SecurityContext rules N/A (no backend or manifest changes)

@amber-review-bot amber-review-bot added the amber/approved The Amber review agent has approved this PR. label Sep 15, 2026
@jsell-rh

Copy link
Copy Markdown
Collaborator

lgtm

@jsell-rh
jsell-rh added this pull request to the merge queue Sep 15, 2026
Merged via the queue into openshift-online:main with commit d47f4cb Sep 15, 2026
30 checks passed
markturansky pushed a commit that referenced this pull request Sep 15, 2026
Align dependency versions across web-console and shared UI packages.

Co-authored-by: jsell-rh <jsell@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amber/approved The Amber review agent has approved this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants