Skip to content

REPLACE-WITH-JIRA-KEY: Bump k8s dependencies to v0.36.2 (k8s 1.36)#239

Draft
dfarrell07 wants to merge 1 commit into
openshift:mainfrom
dfarrell07:bump1.36-20260719212726
Draft

REPLACE-WITH-JIRA-KEY: Bump k8s dependencies to v0.36.2 (k8s 1.36)#239
dfarrell07 wants to merge 1 commit into
openshift:mainfrom
dfarrell07:bump1.36-20260719212726

Conversation

@dfarrell07

Copy link
Copy Markdown

Summary

Bump all k8s.io/* dependencies from v0.35.0 to v0.36.2 (Kubernetes 1.36), with Go version 1.25.0 → 1.26.0.

What changed

  • k8s.io/ deps*: All 8 core modules bumped to v0.36.2
  • sigs.k8s.io/controller-runtime: v0.23.1 → v0.24.1
  • OpenShift deps: openshift/api, openshift/client-go, openshift/library-go updated to latest snapshots tracking k8s 1.36
  • Go version: go directive bumped from 1.25.0 to 1.26.0
  • Removed: github.com/gogo/protobuf (k8s 1.36 completed protobuf migration)
  • New default-true feature gates: AtomicFIFO, ClientsAllowCARotation, ClientsAllowTLSCacheGC, InOrderInformers, UnlockWhileProcessingFIFO

Commits

Commit Type
27b93fa Rebase k8s-rebase-1.36.2 to k8s 1.36 Mechanical (go get + go mod tidy + go mod vendor)

No source code changes were needed — the rebase compiled and passed all checks cleanly.

Verification

All checks passed locally (containerized with Go 1.26.0):

  • go build ./... — PASS
  • go vet ./... — PASS
  • golangci-lint run — PASS
  • go test ./pkg/cloudprivateipconfig ./pkg/cloudprovider ./pkg/controller/cloudprivateipconfig — PASS
  • govulncheck ./... — 0 dep CVEs (15 stdlib vulns in go1.26.0, fixed in go1.26.5)
  • staticcheck -checks SA1019 ./... — 0 deprecated API usage
  • Antagonistic code review — APPROVE

Notes

  • Dockerfile and .ci-operator.yaml already reference Go 1.26 builder images (pre-configured for OCP 5.0)
  • NewSimpleClientset in racy_test.go is deprecated but compiles — pre-existing, not introduced by this rebase
  • WatchListClient is default-on in client-go v0.36 (beta) — low risk for this controller

All commits carry Assisted-by: Claude Code trailers.

go get k8s.io/api@v0.36.2
go get k8s.io/apiextensions-apiserver@v0.36.2
go get k8s.io/apimachinery@v0.36.2
go get k8s.io/apiserver@v0.36.2
go get k8s.io/client-go@v0.36.2
go get k8s.io/cloud-provider@v0.36.2
go get k8s.io/component-base@v0.36.2
go get sigs.k8s.io/controller-runtime@v0.24.1
go get github.com/openshift/api
go get github.com/openshift/client-go
go get github.com/openshift/library-go
go get k8s.io/klog/v2
go get k8s.io/kube-aggregator
go get k8s.io/kube-openapi
go get k8s.io/utils
go get sigs.k8s.io/json
go get sigs.k8s.io/kube-storage-version-migrator
go get sigs.k8s.io/randfill
go get sigs.k8s.io/structured-merge-diff/v6
go get sigs.k8s.io/yaml
go mod tidy

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Assisted-by: Claude Code <noreply@anthropic.com>
@openshift-ci

openshift-ci Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2026
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 525bffff-abcc-4927-9dfc-ca68d11eab9c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dfarrell07
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant