Skip to content

OCPBUGS-64575: Refresh egress IP capacity annotation on informer resync #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssonigra wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

OCPBUGS-64575: Refresh egress IP capacity annotation on informer resync #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions pkg/controller/node/node_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,20 @@ func NewNodeController(
_, err := nodeInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: controller.Enqueue,
UpdateFunc: func(oldN, newN interface{}) {
oldNode, _ := oldN.(*corev1.Node)
newNode, _ := newN.(*corev1.Node)
// Enqueue on informer resync (same ResourceVersion means the object hasn't changed
// in the API server — the informer is just re-delivering the cached object).
// This ensures SyncHandler periodically re-queries the cloud API for current
// capacity, keeping the egress-ipconfig annotation up to date as IPs are
// assigned or released.
if oldNode.ResourceVersion == newNode.ResourceVersion {
controller.Enqueue(newN)
return
}
// Enqueue when an update to the node's taints occurred - for external cloud providers, we must
// catch changes to taint node.cloudprovider.kubernetes.io/uninitialized.
// See https://kubernetes.io/docs/tasks/administer-cluster/running-cloud-controller/
oldNode, _ := oldN.(*corev1.Node)
newNode, _ := newN.(*corev1.Node)
if !reflect.DeepEqual(oldNode.Spec.Taints, newNode.Spec.Taints) {
controller.Enqueue(newN)
}
Expand Down