Skip to content

REPLACE-WITH-JIRA-KEY: Rebase cloud-network-config-controller to k8s 1.36#257

Draft
dfarrell07 wants to merge 1 commit into
openshift:mainfrom
dfarrell07:bump1.36-20260722203305
Draft

REPLACE-WITH-JIRA-KEY: Rebase cloud-network-config-controller to k8s 1.36#257
dfarrell07 wants to merge 1 commit into
openshift:mainfrom
dfarrell07:bump1.36-20260722203305

Conversation

@dfarrell07

@dfarrell07 dfarrell07 commented Jul 22, 2026

Copy link
Copy Markdown

Summary

Rebase all k8s.io/* dependencies from v0.35.0 (k8s 1.35) to v0.36.2 (k8s 1.36), with Go 1.25.0 → 1.26.0.

  • Bumps all 8 core k8s.io modules to v0.36.2
  • Updates controller-runtime from v0.23.1 to v0.24.1
  • Updates OpenShift deps (api, client-go, library-go) to k8s-1.36-compatible pseudo-versions
  • Updates Go directive from 1.25.0 to 1.26.0

What changed

This is a clean mechanical rebase — no non-vendor Go source files were modified. The single commit bumps go.mod, go.sum, and vendor/ (2149 files).

Notable dependency changes:

  • github.com/gogo/protobuf removed (k8s ecosystem migration)
  • go-openapi/jsonpointer and go-openapi/jsonreference moved to v1.0.0
  • k8s.io/kube-aggregator realigned from v0.34.1 to v0.36.2

Commits

SHA Description Type
546b809 Rebase cloud-network-config-controller to k8s 1.36 Mechanical

Verification

All checks passed locally:

  • go build ./... — PASS
  • go vet ./... — PASS
  • golangci-lint — PASS
  • Unit tests (./pkg/...) — PASS (3 packages, ~3.5k test lines)
  • staticcheck -checks SA1019 ./... — PASS (no deprecated API usage)
  • govulncheck ./... — no new CVEs introduced
  • Independent antagonistic review — APPROVE
  • 31 gate checks across 4 validation phases — all PASS

Known issues (pre-existing)

  • .snyk uses per-file vendor exclusions that may not cover 335 new vendor files (tracked as SDN-4462)
  • 15 Go stdlib CVEs in go1.26.0 (fixed in go1.26.1+, requires Go version upgrade)

All commits carry Assisted-by: Claude Code trailers.

go get k8s.io/api@v0.36.2
go get k8s.io/apiextensions-apiserver@v0.36.2
go get k8s.io/apimachinery@v0.36.2
go get k8s.io/apiserver@v0.36.2
go get k8s.io/client-go@v0.36.2
go get k8s.io/cloud-provider@v0.36.2
go get k8s.io/component-base@v0.36.2
go get sigs.k8s.io/controller-runtime@v0.24.1
go get github.com/openshift/api
go get github.com/openshift/client-go
go get github.com/openshift/library-go
go get k8s.io/klog/v2
go get k8s.io/kube-aggregator
go get k8s.io/kube-openapi
go get k8s.io/utils
go get sigs.k8s.io/json
go get sigs.k8s.io/kube-storage-version-migrator
go get sigs.k8s.io/randfill
go get sigs.k8s.io/structured-merge-diff/v6
go get sigs.k8s.io/yaml
go mod tidy

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Assisted-by: Claude Code <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2026
@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0ca0e1d7-02e5-4d2c-8612-4bd138654c93

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dfarrell07
Once this PR has been reviewed and has the lgtm label, please assign tssurya for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant