Skip to content

[NO-JIRA]test(multilineexception): Add test verifying that independent log records are NOT merged when the first line contains an exception keyword. - #3466

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
vparfonov:log9995-test-master
Sep 22, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
vparfonov:log9995-test-master

Conversation

@vparfonov

@vparfonov vparfonov commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Description

Port-forward: #3465

/cc @Clee2691
/assign @jcantrill

Links

Summary by CodeRabbit

  • Tests
    • Added regression coverage ensuring exception keywords in one log record do not merge subsequent independent records.
    • Verified that multiple multiline log messages remain separate and preserve their original content.

…ords are NOT merged when the first line contains an exception keyword.

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9edc55b7-6ecd-4d7d-8524-217510f5302d

📥 Commits

Reviewing files that changed from the base of the PR and between dde56c0 and 7bef5b6.

📒 Files selected for processing (1)
  • test/functional/filters/multilineexception/multiline_exception_test.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The pull request adds a functional regression test for LOG-9963. The test verifies that an exception-related keyword in one application log does not merge later independent records.

Changes

Multiline exception regression

Layer / File(s) Summary
Independent record separation test
test/functional/filters/multilineexception/multiline_exception_test.go
The test deploys multiline error detection, writes three stdout messages, and verifies three separate HTTP log events with the original messages.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 7bef5

The regression test covers the intended behavior with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes reviewer and approver assignments and a dependent PR link, but it does not provide the required explanation of the issue, rationale, or implementation. The main description se… Add a concise description of the regression, explain why independent log records must not be merged, summarize the test implementation and expected result, and include the related issue or JIRA reference if available.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the regression test and the behavior it verifies. It is specific to the main change, although it is longer than necessary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes reviewer and approver assignments and a dependent PR link, but it does not provide the required explanation of the issue, rationale, or implementation. The main description section remains effectively incomplete.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jcantrill

Copy link
Copy Markdown
Contributor

/approve
/lgtm
/label verified

@openshift-ci openshift-ci Bot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 17, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2026
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2026
@jcantrill

Copy link
Copy Markdown
Contributor

/retest

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD dde56c0 and 2 for PR HEAD 7bef5b6 in total

@vparfonov

Copy link
Copy Markdown
Contributor Author

/test e2e-using-bundle

1 similar comment
@vparfonov

Copy link
Copy Markdown
Contributor Author

/test e2e-using-bundle

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD db4924f and 1 for PR HEAD 7bef5b6 in total

@openshift-ci

openshift-ci Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 928795a into openshift:master Sep 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/6.7 verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants