Skip to content

NO-ISSUE: Randomize C2CC suites#6716

Draft
pmtk wants to merge 1 commit into
openshift:mainfrom
pmtk:c2cc/randomize-suites
Draft

NO-ISSUE: Randomize C2CC suites#6716
pmtk wants to merge 1 commit into
openshift:mainfrom
pmtk:c2cc/randomize-suites

Conversation

@pmtk
Copy link
Copy Markdown
Member

@pmtk pmtk commented May 21, 2026

Summary by CodeRabbit

  • Tests
    • Updated test randomization settings across scenario scripts to randomize test suites during execution.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@pmtk: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented May 21, 2026

/test ?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d53ff9d7-cc13-4a60-8ede-c8b324c9c2b6

📥 Commits

Reviewing files that changed from the base of the PR and between 337c3ca and e9e60b0.

📒 Files selected for processing (2)
  • test/scenarios-bootc/el10/presubmits/el102-src@c2cc.sh
  • test/scenarios-bootc/el9/presubmits/el98-src@c2cc.sh

Walkthrough

Two bootc scenario presubmit scripts update the TEST_RANDOMIZATION environment variable from none to suites, enabling randomized test suite execution across EL9 and EL10 test scenarios.

Changes

Test Suite Randomization

Layer / File(s) Summary
Enable test suite randomization in bootc scenarios
test/scenarios-bootc/el10/presubmits/el102-src@c2cc.sh, test/scenarios-bootc/el9/presubmits/el98-src@c2cc.sh
TEST_RANDOMIZATION environment variable is changed from none to suites in both EL10 and EL9 bootc presubmit scenario scripts, enabling randomized test suite execution.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Randomize C2CC suites' accurately reflects the main change: updating TEST_RANDOMIZATION from 'none' to 'suites' in C2CC test scenario scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies TEST_RANDOMIZATION config variable in shell scripts; doesn't change any test names. Tests are Robot Framework suites with stable, deterministic names; check is not applicable.
Test Structure And Quality ✅ Passed PR only modifies shell scripts that configure test execution (setting TEST_RANDOMIZATION environment variable), not Ginkgo test code. Custom check is not applicable.
Microshift Test Compatibility ✅ Passed PR modifies only test configuration shell scripts, not Ginkgo e2e test code. No new tests added, so MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR contains no new Ginkgo e2e tests. Changes are environment variable updates in shell script scenario configuration files only; check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed Changes affect only test scenario scripts (TEST_RANDOMIZATION environment variable), not deployment manifests, operator code, or controllers. Check is out of scope.
Ote Binary Stdout Contract ✅ Passed PR modifies only shell script configuration files that set TEST_RANDOMIZATION=suites; not OTE binaries or code that writes to stdout.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies bash shell scripts, not Ginkgo e2e tests. Check only applies to new Ginkgo tests (It(), Describe(), etc.), which are not present here.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2026
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented May 21, 2026

/test e2e-aws-tests-bootc-el9

1 similar comment
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented May 21, 2026

/test e2e-aws-tests-bootc-el9

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants