Skip to content

Fix issues in the VPA OOM bump-up example#112847

Open
Amine-LG wants to merge 1 commit into
openshift:mainfrom
Amine-LG:fix-vpa-oom-bump-up-example
Open

Fix issues in the VPA OOM bump-up example#112847
Amine-LG wants to merge 1 commit into
openshift:mainfrom
Amine-LG:fix-vpa-oom-bump-up-example

Conversation

@Amine-LG

@Amine-LG Amine-LG commented Jun 5, 2026

Copy link
Copy Markdown

Correct four issues in the nodes-pods-vertical-autoscaler-oom module:

  • Fix incorrect parameter name: oom-min-bump-ratio does not exist in the
    VPA recommender. The correct flag is oom-bump-up-ratio, which is also
    defined in the bullet list above the example and used in the YAML at the
    bottom of the module.

  • Fix incorrect worked example result. Applying the formula shown in the
    module to the stated values (100 MiB memory, 150 MiB for
    oom-min-bump-up-bytes, ratio 1.2) yields max(250, 120) = 250 MiB,
    not 150 MB as previously stated.

  • Standardize memory units to MiB throughout the example paragraph.
    The default for oom-min-bump-up-bytes is 100 * 1024 * 1024 bytes
    (100 MiB). Using MB (decimal) is inconsistent with the binary unit
    system used by Kubernetes and with the bullet list in the same module.

  • Fix YAML syntax: add missing colon to spec: in the example Deployment.

@openshift-ci openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2026
@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown

Hi @Amine-LG. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Amine-LG Amine-LG changed the title Fix VPA OOM bump-up example Fix issues in the VPA OOM bump-up example Jun 5, 2026
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2026
@Amine-LG Amine-LG force-pushed the fix-vpa-oom-bump-up-example branch from aa397d8 to 6f85ad4 Compare June 14, 2026 01:32
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2026
@Amine-LG

Copy link
Copy Markdown
Author

Rebased on latest main. Please take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant