Fix issues in the VPA OOM bump-up example#112847
Conversation
|
Hi @Amine-LG. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
aa397d8 to
6f85ad4
Compare
|
Rebased on latest main. Please take another look. |
Correct four issues in the
nodes-pods-vertical-autoscaler-oommodule:Fix incorrect parameter name:
oom-min-bump-ratiodoes not exist in theVPA recommender. The correct flag is
oom-bump-up-ratio, which is alsodefined in the bullet list above the example and used in the YAML at the
bottom of the module.
Fix incorrect worked example result. Applying the formula shown in the
module to the stated values (100 MiB memory, 150 MiB for
oom-min-bump-up-bytes, ratio 1.2) yields max(250, 120) = 250 MiB,not 150 MB as previously stated.
Standardize memory units to MiB throughout the example paragraph.
The default for
oom-min-bump-up-bytesis 100 * 1024 * 1024 bytes(100 MiB). Using MB (decimal) is inconsistent with the binary unit
system used by Kubernetes and with the bullet list in the same module.
Fix YAML syntax: add missing colon to
spec:in the example Deployment.