Skip to content

Add upgrade behavior for autonode#112867

Open
bchandra-ocp wants to merge 1 commit into
openshift:mainfrom
bchandra-ocp:bchandra-rosahcp-upgrade-autonode
Open

Add upgrade behavior for autonode#112867
bchandra-ocp wants to merge 1 commit into
openshift:mainfrom
bchandra-ocp:bchandra-rosahcp-upgrade-autonode

Conversation

@bchandra-ocp

@bchandra-ocp bchandra-ocp commented Jun 5, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Contributor

ROSA-17 introduces Red Hat build of Karpenter for ROSA with hosted control planes cluster. This PR adds the cluster upgrade behavior section and adjust the existing wording to accommodate the new behavior.

Version(s):

4.22+

Issue:

OSDOCS-20045

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2026
@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 5, 2026
@bchandra-ocp bchandra-ocp force-pushed the bchandra-rosahcp-upgrade-autonode branch from 11cf8a2 to c3986e6 Compare June 5, 2026 18:36
@bchandra-ocp

bchandra-ocp commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

/label sd-docs

@openshift-ci openshift-ci Bot added the SD-docs Label for all Service Delivery PRs label Jun 5, 2026
@bchandra-ocp

bchandra-ocp commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

/label sme-review-needed

@openshift-ci openshift-ci Bot added the sme-review-needed Service Delivery issues that SRE, PMs, QE, engineering, etc. should review label Jun 5, 2026
@bchandra-ocp

bchandra-ocp commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

/label enterprise-4.22

@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown

@bchandra-ocp: The label(s) /label enterprise-4.22 cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, rebase/manual, cluster-config-api-changed, run-integration-tests, verified, ready-for-human-review, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/skip-dependent-bug-check, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, ok-to-test, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, stability-fix-approved, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bchandra-ocp bchandra-ocp marked this pull request as ready for review June 5, 2026 18:51
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2026
@ocpdocs-previewbot

ocpdocs-previewbot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Fri Jun 05 22:57:25 - Prow CI generated the docs preview:

https://112867--ocpdocs-pr.netlify.app/
https://112867--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/upgrading/rosa-hcp-upgrading.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 5, 2026
View reviewed changes
Comment thread modules/rosa-hcp-upgrading-autonode-clusters.adoc

[role="_abstract"]

This section outlines the behavior when the {product-title} cluster is configured with the {autonode} and the instructions for upgrading the cluster. You can view cluster properties to confirm whether autonode is enabled.

@ocpdocs-vale-bot ocpdocs-vale-bot Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.Spacing: Keep one space between words in 'cluster. You'. For more information, see RedHat.Spacing.

joshbranham
joshbranham reviewed Jun 5, 2026
View reviewed changes
Comment thread modules/rosa-hcp-upgrading-autonode-clusters.adoc Outdated

== Optional EC2NodeClass

If you have created optional OpenshiftEC2NodeClass and additional NodePools that reference the EC2NodeClass corresponding to these OpenshiftEC2NodeClass, the worker nodes managed by these OpenshiftEC2NodeClass resources must be upgraded separately. Use the `spec.version` field on OpenshiftEC2NodeClass Custom Resource (CR) to specify the target version (e.g., 4.y.z) to which the NodePools must be upgraded. No newline at end of file

@joshbranham joshbranham Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, if version field is empty, the nodes will track the control plane, regardless of which OpenshiftEC2NodeClass.

By setting a version field, you can control the upgrade yourself.

@bchandra-ocp bchandra-ocp Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good catch. Thanks.

I've fixed.

@bchandra-ocp bchandra-ocp force-pushed the bchandra-rosahcp-upgrade-autonode branch 2 times, most recently from 632b72c to c27bffd Compare June 5, 2026 21:09
@bchandra-ocp
Add upgrade behavior for autonode
53684fb 
Add upgrade behavior for autonode with branding

Add upgrade behavior for autonode with SME review

Add upgrade behavior for autonode - brevity

Add upgrade behavior for autonode - spec.version
@bchandra-ocp bchandra-ocp force-pushed the bchandra-rosahcp-upgrade-autonode branch from c27bffd to 53684fb Compare June 5, 2026 22:48
@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown

@bchandra-ocp: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2026
@openshift-ci

openshift-ci Bot commented Jun 13, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@joshbranham joshbranham joshbranham left review comments
@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. SD-docs Label for all Service Delivery PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sme-review-needed Service Delivery issues that SRE, PMs, QE, engineering, etc. should review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bchandra-ocp @ocpdocs-previewbot @joshbranham @ocpdocs-vale-bot