Skip to content

OSDOCS-16851-4-CQA: Fourth CQA for OVNK2 Egress Traffic and Gateway co…#112878

Merged
dfitzmau merged 1 commit into
openshift:mainfrom
dfitzmau:OSDOCS-1685-4-CQA
Jun 15, 2026
Merged

OSDOCS-16851-4-CQA: Fourth CQA for OVNK2 Egress Traffic and Gateway co…#112878
dfitzmau merged 1 commit into
openshift:mainfrom
dfitzmau:OSDOCS-1685-4-CQA

Conversation

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 8, 2026
@dfitzmau dfitzmau force-pushed the OSDOCS-1685-4-CQA branch 3 times, most recently from 2f4154d to eeebeb9 Compare June 8, 2026 10:47
@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2026
@dfitzmau dfitzmau force-pushed the OSDOCS-1685-4-CQA branch 3 times, most recently from 4a53fae to 6a2ccd3 Compare June 8, 2026 11:13
@dfitzmau dfitzmau force-pushed the OSDOCS-1685-4-CQA branch from 6a2ccd3 to f325a43 Compare June 8, 2026 11:54
@dfitzmau dfitzmau added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 8, 2026
+
`spec.selector.app`:: Specifies the label for the egress router. The value shown is added by the Cluster Network Operator and is not configurable.

After you create the service, your pods can connect to the service. The egress router pod redirects traffic to the corresponding port on the destination IP address. The connections originate from the reserved source IP address.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDocDITA.TaskStep: Content other than a single list cannot be mapped to DITA steps.

@jeana-redhat

Copy link
Copy Markdown
Contributor

The branch/enterprise-5.0 label has been added to this PR.

This is because your PR targets the main branch and is labeled for branch/enterprise-4.22. And any PR going into main must also target the latest version branch (branch/enterprise-5.0).

If the update in your PR does NOT apply to version 5.0 onward, please re-target this PR to go directly into the appropriate enterprise- version branch or branches instead of main.

@dfitzmau dfitzmau changed the title OSDOCS-16851-4-CQA: Fouth CQA for OVNK2 Egress Traffic and Gateway co… OSDOCS-16851-4-CQA: Fourth CQA for OVNK2 Egress Traffic and Gateway co… Jun 9, 2026
@bscott-rh bscott-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 12, 2026

@bscott-rh bscott-rh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small fixes, then it's good to go.

Comment thread modules/nw-egress-ips-node.adoc Outdated
<1> Specify the label for the egress router. The value shown is added by the Cluster Network Operator and is not configurable.
+
`spec.selector.app`:: Specifies the label for the egress router. The value shown is added by the Cluster Network Operator and is not configurable.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+

Need this to include the text on the next line in the proc step. Otherwise vale complains

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@bscott-rh bscott-rh added ok-to-merge and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Jun 12, 2026
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2026
@dfitzmau dfitzmau force-pushed the OSDOCS-1685-4-CQA branch from f325a43 to 4966886 Compare June 15, 2026 08:25
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2026
@dfitzmau dfitzmau force-pushed the OSDOCS-1685-4-CQA branch from 4966886 to f67e553 Compare June 15, 2026 08:29
@dfitzmau dfitzmau force-pushed the OSDOCS-1685-4-CQA branch from f67e553 to f0a5512 Compare June 15, 2026 08:47
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau merged commit 80537b0 into openshift:main Jun 15, 2026
2 checks passed
@dfitzmau

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.22

@dfitzmau

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.21

@dfitzmau

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.20

@dfitzmau

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-5.0

@openshift-cherrypick-robot

Copy link
Copy Markdown

@dfitzmau: new pull request created: #113319

Details

In response to this:

/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@dfitzmau: new pull request created: #113320

Details

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@dfitzmau: new pull request created: #113321

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@dfitzmau: new pull request created: #113322

Details

In response to this:

/cherrypick enterprise-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants