Skip to content

config: add stolostron/capi-tests CAPZ e2e jobs#3377

Merged
openshift-merge-bot[bot] merged 4 commits into
openshift:mainfrom
RadekCap:add-capz-qe-jobs
Jun 23, 2026
Merged

config: add stolostron/capi-tests CAPZ e2e jobs#3377
openshift-merge-bot[bot] merged 4 commits into
openshift:mainfrom
RadekCap:add-capz-qe-jobs

Conversation

@RadekCap

@RadekCap RadekCap commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add capi-qe section to openshift-customizations.yaml to register stolostron/capi-tests CAPZ e2e jobs in Sippy
  • Registers the periodic job (periodic-ci-stolostron-capi-tests-configure-prow-mgmt-periodics-capz-e2e and pull-ci-stolostron-capi-tests-configure-prow-mgmt-capz-e2e) by exact name

🤖 Generated with Claude Code

@openshift-ci-robot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Adds CAPZ job enablement flags to config/openshift-customizations.yaml: a new top-level releases.capi-qe section with a CAPZ periodic job flag, and a CAPZ Azure ARO HCP job flag under the existing releases.aro-production section.

Changes

Release Configuration Updates

Layer / File(s) Summary
CAPZ job flags in releases
config/openshift-customizations.yaml
Adds releases.capi-qe.jobs.periodic-ci-stolostron-capi-tests-configure-prow-mgmt-periodics-capz-e2e: true under a new release section, and adds releases.aro-production.jobs.periodic-ci-Azure-ARO-HCP-main-capz-e2e-production: true under the existing ARO production jobs block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 21
✅ Passed checks (21 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed PR only modifies config/openshift-customizations.yaml (YAML configuration file), not Go code. Go error handling check is not applicable to YAML configuration changes.
Sql Injection Prevention ✅ Passed This PR modifies only config/openshift-customizations.yaml, a YAML configuration file containing job registration definitions. No SQL code is present or modified in this PR; the custom check for...
Excessive Css In React Should Use Styles ✅ Passed The PR modifies only config/openshift-customizations.yaml (YAML configuration). The check for "Excessive CSS in React" is not applicable as there are no React components, JavaScript, or CSS code in...
Test Coverage For New Features ✅ Passed PR modifies only config/openshift-customizations.yaml (configuration-only change), which is exempt from test coverage requirements per the custom check exceptions.
Single Responsibility And Clear Naming ✅ Passed The capi-qe section follows single responsibility (one release concept) and clear naming principles. The name "capi-qe" is descriptive and unambiguous; the structure mirrors other releases with con...
Feature Documentation ✅ Passed PR adds a new synthetic release (capi-qe) to config/openshift-customizations.yaml. While docs/plans/trt-2588-config-hierarchy.md lists all synthetic releases and should ideally be updated, the cust...
Stable And Deterministic Test Names ✅ Passed PR modifies config/openshift-customizations.yaml only, a Prow job registration file with no Ginkgo tests. The check for stable/deterministic Ginkgo test names is not applicable to configuration files.
Test Structure And Quality ✅ Passed PR modifies only config/openshift-customizations.yaml (YAML configuration file). The custom check applies to Ginkgo test code (*_test.go), which is not present in this PR.
Microshift Test Compatibility ✅ Passed This PR only modifies a YAML configuration file to register existing CAPZ e2e jobs in Sippy's dashboard. No new Ginkgo test code is added, so the MicroShift compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies openshift-customizations.yaml to register existing jobs in Sippy; no new Ginkgo e2e tests (It(), Describe(), Context(), When()) are added.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only a CI job tracking configuration file (openshift-customizations.yaml) in Sippy, not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed This PR only modifies config/openshift-customizations.yaml (a YAML configuration file), not executable code. The OTE Binary Stdout Contract check is designed to detect stdout writes in Go process-l...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. It only modifies the YAML configuration file (openshift-customizations.yaml) to register existing CAPZ e2e jobs in Sippy. The check is not applicable.
No-Weak-Crypto ✅ Passed Pull request only modifies a YAML configuration file adding CI job entries; no cryptographic code, weak crypto algorithms, custom crypto implementations, or insecure comparisons are present.
Container-Privileges ✅ Passed File is a Sippy job configuration overlay, not a K8s manifest. No privileged container configurations, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation found.
No-Sensitive-Data-In-Logs ✅ Passed PR only modifies openshift-customizations.yaml with YAML configuration entries (job names). No logging statements or sensitive data (passwords, tokens, API keys, PII) are present.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: adding CAPZ e2e jobs from stolostron/capi-tests to the configuration file, which aligns with the changeset that adds job enablements for these CAPZ e2e workflows.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from deepsm007 and sosiouxme March 27, 2026 09:31
@openshift-ci-robot

Copy link
Copy Markdown

Scheduling required tests:
/test e2e

@marek-veber marek-veber left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2026
@RadekCap

Copy link
Copy Markdown
Contributor Author

/assign dgoodwin

@RadekCap

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown

Scheduling required tests:
/test e2e

@RadekCap

Copy link
Copy Markdown
Contributor Author

Can anybody please do review here? Thank you. This is currently blocking our next work.

I wouldn't ping you all but I don't know where to ask properly and I don't want to ping you personally on Slack or elsewhere.

@deads2k
@deepsm007
@dgoodwin
@neisw
@petr-muller
@stbenjam
@xueqzhan
@sosiouxme
@smg247

Comment thread config/openshift-customizations.yaml Outdated
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2026
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 9, 2026
RadekCap and others added 3 commits June 15, 2026 11:31
Register the CAPZ QE periodic and presubmit jobs in Sippy so they
appear in the dashboard.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace the overly broad regexp with an exact job entry for
pull-ci-stolostron-capi-tests-configure-prow-mgmt-capz-e2e.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Rename the section from capz-qe to capi-qe and remove the
pull-ci-stolostron-capi-tests-configure-prow-mgmt-capz-e2e job entry,
keeping only the periodic job.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@RadekCap RadekCap changed the title config: add stolostron/capi-tests CAPZ e2e jobs config: add CAPZ e2e jobs (capi-qe + aro-production) Jun 22, 2026
@RadekCap RadekCap changed the title config: add CAPZ e2e jobs (capi-qe + aro-production) config: add stolostron/capi-tests CAPZ e2e jobs Jun 22, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@config/openshift-customizations.yaml`:
- Line 39: The capi-qe release section is missing the synthetic: true flag that
all other pseudoreleases in this file have (such as aro-integration, aro-stage,
aro-production, aro-classic-integration). Add the synthetic: true flag to the
capi-qe section to maintain consistency with the existing pattern used by other
pseudoreleases in the configuration file.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2707701d-253a-4225-b1fa-b8daee08a278

📥 Commits

Reviewing files that changed from the base of the PR and between 49215c4 and b589cae.

📒 Files selected for processing (1)
  • config/openshift-customizations.yaml

Comment thread config/openshift-customizations.yaml
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@smg247

smg247 commented Jun 23, 2026

Copy link
Copy Markdown
Member

@RadekCap, I have added the necessary Release info to BigQuery, and this should show up once we get this PR merged with the requested change. After data loading, that is.

@RadekCap RadekCap requested review from marek-veber, neisw and smg247 June 23, 2026 19:11

@marek-veber marek-veber left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@smg247

smg247 commented Jun 23, 2026

Copy link
Copy Markdown
Member

@RadekCap you still haven't set synthetic: true

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2026
@RadekCap

Copy link
Copy Markdown
Contributor Author

@RadekCap you still haven't set synthetic: true

@smg247 You're right, fixed. Thank you.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@smg247

smg247 commented Jun 23, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2026
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marek-veber, RadekCap, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2026
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@RadekCap: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 24c082b into openshift:main Jun 23, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants