use TIMENOW placeholder in job runs matview#3653
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
Warning Review limit reached
More reviews will be available in 59 minutes and 55 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Skipping CI for Draft Pull Request. |
prow_job_runs_report_matview was the only matview using CURRENT_TIMESTAMP instead of the |||TIMENOW||| placeholder. This meant it always evaluated against wall-clock time, ignoring the --pinned-time flag that other matviews respect. As a result, the matview returned zero rows when run against seed data (whose timestamps are at fixed dates in the past). Replace all three CURRENT_TIMESTAMP occurrences with |||TIMENOW|||, which resolves to NOW() in production and to the pinned timestamp when --pinned-time is set. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
953e636 to
e0dc60a
Compare
|
Scheduling required tests: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mstaeble, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
CURRENT_TIMESTAMPwith|||TIMENOW|||inprow_job_runs_report_matviewCURRENT_TIMESTAMPdirectlyProblem
The
|||TIMENOW|||placeholder is replaced withNOW()in production, but with a fixedTO_TIMESTAMP(...)when--pinned-timeis set (used by the seed data workflow). Because this matview usedCURRENT_TIMESTAMPinstead, it always evaluated against wall-clock time and returned zero rows against seed data whose timestamps are at fixed dates in the past.Introduced in PR #3616, which added the 90-day time bound using
CURRENT_TIMESTAMPrather than the existing|||TIMENOW|||convention.Test plan
go build ./...go vet ./...CURRENT_TIMESTAMPin matview definitionssippy migrate🤖 Generated with Claude Code