Skip to content

Add Octavia SKMO playbooks for amphora and network setup#3965

Open
vakwetu wants to merge 1 commit into
openstack-k8s-operators:mainfrom
vakwetu:add-octavia-amphora-wait-skmo
Open

Add Octavia SKMO playbooks for amphora and network setup#3965
vakwetu wants to merge 1 commit into
openstack-k8s-operators:mainfrom
vakwetu:add-octavia-amphora-wait-skmo

Conversation

@vakwetu

@vakwetu vakwetu commented May 26, 2026

Copy link
Copy Markdown
Contributor

Add SKMO OVN Octavia Tempest support for leaf region
Add EDPM recreate hook and extend network-values templates for Octavia
NAD generation. Leaf-region Tempest config lives in ci-framework-jobs
05-tests.yaml; reproducer uses post_tests: [] like the uni job.

Depends-On: openstack-k8s-operators/architecture#759

Signed-off-by: Ade Lee alee@redhat.com
Assisted-by: Claude Opus 4.6

@openshift-ci

openshift-ci Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign brjackma for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@evallesp

Copy link
Copy Markdown
Contributor

First commit already reviewed in #3956
Do we want to close that MR? I'd rather go removing that commit from this MR.

@evallesp evallesp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM

Comment thread hooks/playbooks/skmo/configure-octavia-network.yaml Outdated
Comment thread hooks/playbooks/skmo/configure-octavia-network.yaml Outdated
set -xe -o pipefail
oc debug node/{{ item }} -- chroot /host ip link set br-octavia up
loop: "{{ cifmw_skmo_master_nodes }}"
changed_when: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(blocking) suggestion: I think it's safe to remove this changed_when.

@evallesp

Copy link
Copy Markdown
Contributor

First commit already reviewed in #3956 Do we want to close that MR? I'd rather go removing that commit from this MR.

it was merged.

@vakwetu vakwetu force-pushed the add-octavia-amphora-wait-skmo branch from e1bc8e2 to e1304ee Compare May 28, 2026 19:51
@vakwetu

vakwetu commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

removed merged commit.

PATH: "{{ cifmw_path }}"
ansible.builtin.shell: |
set -xe -o pipefail
oc debug node/{{ item }} -- chroot /host ip link set br-octavia up

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember that we had to do that in other jobs, is it something specific to this job?

…af region

Add EDPM recreate hook and extend network-values templates for Octavia
NAD generation. Leaf-region Tempest config lives in ci-framework-jobs
05-tests.yaml; reproducer uses post_tests: [] like the uni job.

Depends-On: openstack-k8s-operators/architecture#759

Signed-off-by: Ade Lee <alee@redhat.com>
Assisted-by: Claude Opus 4.6
@vakwetu vakwetu force-pushed the add-octavia-amphora-wait-skmo branch from 9c05293 to f1da49a Compare June 9, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants