[test_operator] Fix test_operator_results overwrite for multi-stage runs#3976
Open
srac0 wants to merge 1 commit into
Open
[test_operator] Fix test_operator_results overwrite for multi-stage runs#3976srac0 wants to merge 1 commit into
srac0 wants to merge 1 commit into
Conversation
When cifmw_test_operator_stages contains multiple stages of the same type, the results dict key was just the framework name. Each stage overwrote the previous result, so a failing middle stage was silently masked if the final stage succeeded. Include the stage name in the dict key so each stage gets its own entry. The assert at the end of main.yml iterates dict2items, so it checks all entries without further changes. Signed-off-by: Samuel Rac <srac@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cifmw_test_operator_stages contains multiple stages of the same type, the results dict key was just the framework name. Each stage overwrote the previous result, so a failing middle stage was silently masked if the final stage succeeded.
Include the stage name in the dict key so each stage gets its own entry. The assert at the end of main.yml iterates dict2items, so it checks all entries without further changes.