Feedback button changes.#1440
Open
somiaj wants to merge 1 commit into
Open
Conversation
somiaj
force-pushed
the
feedback-changes
branch
3 times, most recently
from
8d461f4 to
0e7eb5b
Compare
Member
|
About the circle, I think the font awesome one looks good. Here it is: |
This changes the feedback buttons in two ways. 1) Use copies of the bootstrap classes to color buttons. This way the feedback colors don't get changed by theming on the client side. The themes can still modify the actual classes used to change the buttons if desired, but the feedback buttons themselves can be themed independently of other bootstrap buttons. 2) Create a new feedback class "unknown" to use when showing the results of a problem with `$showPartialCorrectAnswers=0`. Currently on problems with limited feedback, it can be unclear to the student that they actually submitted the answer vs previewed the answer. This is accomplished by marking the buttons as incorrect if no answer is correct (0% on the problem), and marking them as "unknown" which shows a yellow button with a question mark in a circle if the problem is partially correct.
Contributor
Author
|
Thanks I updated this to be the icon. |
Contributor
Author
|
After the meeting it seemed that others were okay with these changes so I'll change it from a draft so it can be fully reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using this PR as a discussion (so it is a draft). I'm unsure what others will think of these changes, but this is to address two issues I have with the feedback buttons. I have attempted to implement suggested changes to address the issues.
The first is themes can change the feedback button colors since they are using the bootstrap color classes. This may not be desirable that the feedback buttons match the webwork button colors, so new classes are created for the feedback buttons that can be themed independently of the bootstrap classes.
The second is when
$showPartialCorrectAnswers=0and the student didn't get the problem correct, the feedback looks like a "Preview Answers" and it confuses students as they think they hit "Preview Answers" and not "Submit Answer" button. This makes it so the feedback has its own look for this case. It uses the yellow color for partially correct, a title of "Unknown" (I think something better could be used here to indicate it is unknown if the answer is correct or incorrect) and a question mark in a circle as the icon (my question mark needs to be improved, I had trouble finding a good SVG question mark).