Merge develop into infrahub-develop#1055
Merged
Merged
Conversation
Add docstrings to related node
Merge stable into develop
Deploying infrahub-sdk-python with
|
| Latest commit: |
f03ced5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6e54b94.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://develop.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## infrahub-develop #1055 +/- ##
====================================================
- Coverage 81.87% 81.71% -0.17%
====================================================
Files 134 135 +1
Lines 11676 11637 -39
Branches 1735 1759 +24
====================================================
- Hits 9560 9509 -51
- Misses 1569 1576 +7
- Partials 547 552 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging develop into infrahub-develop after merging pull request #1054.
Summary by cubic
Fix
infrahubctlexit handling by lettingtyper.Exitpass through so commands exit cleanly with only the intended error (no traceback or "Error: 1"). Add docstrings and docs forRelatedNode/RelatedNodeSync(id,peer,get) to clarify id resolution and whenpeer.idcan differ from.id.Written for commit f03ced5. Summary will update on new commits.