[BUG-8620] Make DefaultJsonSerializer resilient to init failures#626
Open
muzahidul-opti wants to merge 2 commits into
Open
[BUG-8620] Make DefaultJsonSerializer resilient to init failures#626muzahidul-opti wants to merge 2 commits into
muzahidul-opti wants to merge 2 commits into
Conversation
…ilures Wrap each serializer instantiation in try-catch so that if one library's initialization fails (e.g., Jackson's PropertyNamingStrategies fields obfuscated by R8), the factory falls through to the next available JSON library instead of crashing with NoClassDefFoundError. Also add DefaultJsonSerializer unit tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultJsonSerializer.create()with try-catch so that if one library's initialization fails (e.g., Jackson'sPropertyNamingStrategiesfields obfuscated by R8), the factory falls through to the next available JSON library instead of crashing withNoClassDefFoundErrorThrowable(not justException) to handleNoClassDefFoundError,ExceptionInInitializerError, and similar linkage errorsDefaultJsonSerializerTestwith smoke tests for the singletonContext
PetSmart reports that event dispatch fails with
NoClassDefFoundError: DefaultJsonSerializer$LazyHolderwhen Jackson is on the classpath with itsPropertyNamingStrategies.SNAKE_CASEfield obfuscated by R8. The currentcreate()method doesn't handle serializer constructor failures, so a Jackson init failure kills the entire serializer factory.Companion PR: android-sdk ProGuard rules (defense-in-depth)
Test plan
JacksonSerializerTest,GsonSerializerTest,JsonSerializerTest,JsonSimpleSerializerTest)DefaultJsonSerializerTestpasses (3 tests)Issue
🤖 Generated with Claude Code