Use aria2 prefetch fallback for octavia image import#2462
Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider making the increased octavia image task timeout (5400s) a configurable value rather than a hardcoded constant so it can be tuned for different environments without code changes.
- Since this change assumes an image-manager release with the
--prefetchoption, consider adding a guard or version/feature check so the manager fails fast with a clear message if it is used with an older image-manager that lacks this flag.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider making the increased octavia image task timeout (5400s) a configurable value rather than a hardcoded constant so it can be tuned for different environments without code changes.
- Since this change assumes an image-manager release with the `--prefetch` option, consider adding a guard or version/feature check so the manager fails fast with a clear message if it is used with an older image-manager that lacks this flag.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ideaship
marked this pull request as draft
July 14, 2026 04:45
ideaship
marked this pull request as ready for review
July 14, 2026 05:37
ideaship
marked this pull request as draft
July 14, 2026 06:46
ideaship
marked this pull request as ready for review
July 14, 2026 07:34
The image-manager can now fall back to downloading an image with aria2c and importing it via glance-direct when Glance's web-download stalls (used for the octavia amphora image). Add the aria2 package to the manager image so the aria2c binary is available at runtime. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Roger Luethi <luethi@osism.tech>
The octavia amphora image import can now fall back from web-download to aria2 + glance-direct, which adds a local ~1 GB download and a staging upload on top of the normal import. Raise this task's timeout from 3600 to 5400 seconds so the fallback has room to complete within the budget; the other image-manager tasks are unchanged. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Roger Luethi <luethi@osism.tech>
The amphora image source is chronically slow, so a stuck web-download import rarely recovers on an immediate retry -- the retry just spends another multi-minute doomed transfer. Set --stuck-retry to 0 so there is a single web-download attempt; on its failure the default --prefetch on-stuck path falls back to aria2 + glance-direct, which is the robust recovery. Good-path imports are unchanged (web-download still tried once). Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wires the OSISM manager to use the aria2 + glance-direct import fallback for the
octavia amphora image, whose source download from object storage is chronically
slow (see osism/issues#1411).
Changes
aria2in the manager image (providesaria2cfor the prefetch path).download + staging on top of the import.
--stuck-retry 0: a single web-download attempt, then fall back toaria2 + glance-direct (the default
--prefetch on-stuck) — retrying the slowsource just wastes another multi-minute transfer.
Merge order
--stuck-retry 0is only safe once the fallback exists in the installedimage-manager; shipping it earlier would leave octavia with a single web-download
attempt and no fallback — less resilient than today's two attempts. So this PR is
kept in draft and merged only together with the pin bump:
openstack-image-managerrelease containing itrequirements.openstack-image-manager.txtto that release on thisbranch, take this PR out of draft, and merge
aria2install and the timeout bump are harmless on their own; keeping them herewith the pin makes the whole change atomic.
Related
🤖 Generated with Claude Code