refactor: [DC-324] decouple retrieving server settings and user info from connection validator routines - #12619
Draft
modSpike wants to merge 6 commits into
Draft
refactor: [DC-324] decouple retrieving server settings and user info from connection validator routines#12619modSpike wants to merge 6 commits into
modSpike wants to merge 6 commits into
Conversation
it leaks at the moment as there are issues with deleting the job on finished signal. that needs to be fixed in the job by ensuring the "asyncUpdates" are finished before the finished signal is emitted. alternately can call those extra operations from the AccountState but I think having it all in the job is simpler.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
modSpike
marked this pull request as draft
August 20, 2026 11:07
committing it for discussion with cohort
this is a very questionable impl. The core problem is not being able to simply delete the settings job, in tandem with questionable "need" to have that be null by the time the folders are enqueued. will discuss next week and clean it up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://kiteworks.atlassian.net/browse/DC-324