Terminal: Disable bold, tweak line height#3215
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
benjaminleonard
changed the title
Contributor
Author
charliepark
approved these changes
Jun 3, 2026
Contributor
charliepark
left a comment
charliepark
left a comment
There was a problem hiding this comment.
Sorry to have missed this earlier. Looks good.
charliepark
reviewed
Jun 3, 2026
| lineHeight: 1, | ||
| fontWeightBold: 400, | ||
| drawBoldTextInBrightColors: true, | ||
| letterSpacing: 0, |
Contributor
There was a problem hiding this comment.
The robot notes that these two (drawBoldTextInBrightColors: true and letterSpacing: 0) are xterm v6 defaults, so might not be necessary.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line Height
In xterm.js,
lineHeightis a multiplier on the measured cell height, not the font size. So alineHeightof 1 is actually closer to what we'd expect here.Bold
There seems to be a bug where setting bold makes the cell width wider. Not sure if this is on
xterm.jsor its the font metrics. Better instead to just disable bold.Before:
After:
