Instance jumbo frames setting#3235
Draft
david-crespo wants to merge 4 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Rather than making the system endpoint accessible, can we add some sort of environment endpoint that plumbs it through for developers also. One other example could be the |
Collaborator
Author
|
Yeah, that’s interesting. My instinct is to avoid putting together networking and CPU settings in the same endpoint, but it would also be silly to have 3 different endpoints with one setting each. |
The new jumbo frames settings card adds a second Save button to the
instance settings tab, so the bare getByRole('button', { name: 'Save' })
in instance-auto-restart.e2e.ts hit a strict-mode violation in CI.
david-crespo
added a commit
that referenced
this pull request
Jun 3, 2026
…rue (#3238) Straightforward. The interesting bit here is the addition of an `msw-flags` cookie that we can use in the test to flip `contact_support: true` instead of hang it off a particular test user, which I tried and felt wrong. We can also use it for the jumbo frames setting in #3235 until we have an operator UI for flipping the setting (which we should probably have?). ## `contact_support: false` <img width="1210" height="860" alt="image" src="https://github.com/user-attachments/assets/bedb6e0f-ceef-47d0-a938-85f9449451d0" /> ## `contact_support: true` <img width="1211" height="862" alt="image" src="https://github.com/user-attachments/assets/c35996b4-2c1c-41b7-80ca-141418db833c" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP to get a feel for it. See oxidecomputer/omicron#10472. It's pretty good as-is — the worst part is that we don't currently have a way of fetching the system-level jumbo frames setting, which would let us hide this setting on the instance page if it was off system-wide (probably true for the majority of users). It feels bad to have a setting on the page that will never work, but at least the copy makes it reasonably clear. We could either add a silo-level network settings endpoint that makes this setting available to end users OR cheat by making the system-level endpoint readable by any logged-in user.