Convert to slog as our logging library#688
Open
mkeeter wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
One thing that I'd like opinions on: should we re-export the |
167509f to
60a6c6b
Compare
Contributor
Author
I've decided that I like this, but it's in a standalone commit at the top of the stack if anyone strongly disagrees. |
2b7fc12 to
edea013
Compare
edea013 to
c821ad3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFD 659, this converts us to using
slogeverywhere.This PR is mostly mechanical!
slogexpects a logger object to be threaded through function calls. Here, we lazily construct it in theCli, then grab it from theExecutionContext. It's mostly passed as an argument, although in places where we build anXyzContext(e.g.HiffyContext), we clone a copy of the logger and store it locally to reduce boilerplate.(cloning a
slog::Loggeris expected to be cheap)Note that we still use
env_loggerfor configuration in thehumility-binpackage, so that we can get verboseprobe-rslogs (and maybe other libraries as well, but that's the loudest one).