Remove more probe-specific functions from Core#692
Open
mkeeter wants to merge 5 commits into
Open
Conversation
78185e4 to
d8ec344
Compare
b2d785b to
dd14be6
Compare
d8ec344 to
f8afcff
Compare
dd14be6 to
e4e0918
Compare
f8afcff to
403b7a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
reset,reset_and_halt, andwait_for_haltfrom theCoretrait. These functions are only implemented onProbeCore(andUnattachedCore::reset), so removing them from the trait lets us be more precise with our APIs.(
wait_for_haltis not used anywhere, so it's been fully deleted).The only tricky part is
AuxFlashHandler, which only sometimes needs a fullProbeCore– basically only when writing. I added a newstruct AuxFlashWriter, then anAuxFlashWorkertrait to unify common functions (e.g. getting slot count, and active slot). This is a bit annoying, but minimizes boilerplate; I couldn't find a way to write a type which accepts either a&mut dyn Coreor a concreteC: Corewithout replumbing everything.