Repository navigation
[rejected AI] Fix indent filter handling of empty first lines - #2270
Closed
LouisDeconinck wants to merge 1 commit into
Closed
LouisDeconinck wants to merge 1 commit into
LouisDeconinck wants to merge 1 commit into
Conversation
Member
davidism
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2176
The
indentfilter currently prepends the indentation string whenfirst=True, even if the first line is empty andblank=False. This produces whitespace for an empty filtered block.Use the first line's content when deciding whether
firstshould indent, while preservingblank=Truebehavior. The existing filter tests now cover the regression.Checks:
git diff --checkThe change is limited to the filter, its regression test, and
CHANGES.rst.