Repository navigation
pkg/normalizer: populate function name for v2 arrow locations - #6413
Merged
Merged
Conversation
|
✅ Meticulous spotted 0 visual differences across 282 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit |
The v2 arrow schema only carries a function system_name, and encodeV2Location wrote the function name as the empty string. The flame graph and table read only the function name, so every pre-symbolized frame (e.g. agent-symbolized kernel frames) came out unnamed: siblings merged into a single node keyed on "" and the UI fell back to rendering the module-relative address. Write system_name as both name and system_name on ingest, and have DecodeInto/DecodeFunctionName fall back to system_name when the name is empty so data already stored by the old v2 path displays correctly.
gnurizen
force-pushed
the
fix-v2-kernel-frame-names
branch
from
September 29, 2026 18:22
8447128 to
dd5fcd5
Compare
gnurizen
marked this pull request as ready for review
September 29, 2026 18:30
brancz
enabled auto-merge (squash)
September 29, 2026 18:34
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kernel frames sent through the v2 Arrow write path appear as bare addresses or
<unknown>in the flame graph, although the agent sends the symbol.Cause
The v2 schema has only
system_nameon the function struct; the agent puts the kernel symbol there.encodeV2Locationwrote the function name as"". The flame graph (flamegraph_arrow.go) and table read onlyfunction_name, so for every pre-symbolized v2 frame:location_addressgoes null wherever the merged addresses differnodeLabelfalls back to[mapping]0x<addr>, where the address is module-relativeFix
pkg/normalizer/arrow_v2.go): writesystem_nameas both the name andsystem_name. Query-time demangling already runs over the name.pkg/profile/decode.go):DecodeIntoandDecodeFunctionNamefall back tosystem_namewhen the name is empty, so profiles already stored by the old v2 path display correctly (FrostDB). Once that data ages out of retention, the fallback can be removed.Testing
TestAddSampleRecordV2now asserts that the encoded location carries the symbol as both name and system name.TestDecodeFallsBackToSystemNamecovers the legacy encoding.pkg/profile,pkg/normalizer,pkg/parcacolandpkg/querytests pass.