Skip to content

chore(Popover): Include OUIAProps for Popover#12572

Open
mshriver wants to merge 1 commit into
patternfly:mainfrom
mshriver:popover-ouia
Open

chore(Popover): Include OUIAProps for Popover#12572
mshriver wants to merge 1 commit into
patternfly:mainfrom
mshriver:popover-ouia

Conversation

@mshriver

@mshriver mshriver commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Add OUIA attribute support to Popover for better test automation. OUIA attributes are applied to the FocusTrap dialog root.

What:
Closes #12571

Snapshot tests commit
#12573
https://github.com/patternfly/patternfly-react/pull/12574/changes

Summary by CodeRabbit

  • New Features

    • Added OUIA support to the Popover component.
    • Popovers now expose component type, custom component ID, and safety attributes for testing and automation.
    • Added controls for setting a custom OUIA ID and safety behavior.
  • Documentation

    • Listed Popover among OUIA-compliant components.

Add OUIA attribute support to Popover for better test automation. OUIA
attributes are applied to the FocusTrap dialog root.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Popover now supports OUIA properties, applies generated OUIA attributes to its internal focus trap, adds tests for those attributes, and lists Popover among OUIA-compliant react-core components.

Changes

Popover OUIA integration

Layer / File(s) Summary
OUIA contract and attribute wiring
packages/react-core/src/components/Popover/Popover.tsx
PopoverProps now includes ouiaId and ouiaSafe; Popover generates OUIA props and applies them to FocusTrap.
OUIA validation and documentation
packages/react-core/src/components/Popover/__tests__/Popover.test.tsx, packages/react-core/src/helpers/OUIA/OUIA.md
Tests verify OUIA component ID, component type, and safe attributes, and the OUIA component list now includes Popover.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR adds OUIA support to Popover and tests the new attributes, matching issue #12571.
Out of Scope Changes check ✅ Passed The changes are limited to Popover OUIA support, its tests, and related documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding OUIAProps support to Popover.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Popover missing OUIA support

1 participant