Column Management Modal retains unapplied checkbox changes on Cancel #942

Activity

1. patternfly-build

   added this to PatternFly Issueson Jun 3, 2026
2. github-project-automation

   moved this to Needs triage in PatternFly Issueson Jun 3, 2026
3. rh-gvincent commented on Jun 30, 2026

   

   rh-gvincent

   on Jun 30, 2026

   Author

   More actions

   Looking at the test, I noticed this:

   it('should retain columns on cancel', () => {
     fireEvent.click(screen.getByText('Impact'));
     fireEvent.click(screen.getByText('Cancel'));
   
     expect(onClose).toHaveBeenCalled();
     // applyColumns should NOT be called on cancel
     expect(setColumns).not.toHaveBeenCalled();
   });
   

   Is this behavior intentional?

   I would expect clicking Cancel (or closing the dialog) to discard any pending changes and restore the initial state. But maybe the original design was intentionally different?