Decouple directory poll timing#1658
Open
bc1cindy wants to merge 4 commits into
Open
Conversation
Collaborator
Coverage Report for CI Build 27853602031Coverage decreased (-0.04%) to 85.171%Details
Uncovered Changes
Coverage Regressions21 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
benalleng
reviewed
Jun 19, 2026
benalleng
reviewed
Jun 19, 2026
Collaborator
There was a problem hiding this comment.
CACK c9a0ceb
Tested against master test poll timing.
master ran 5 send_receive_payjoin_v2_* payjoin-cli e2e tests with the following data
I tried to do a little more precise per-poll timing but I found that to be too much signal for the purpose of my smoke testing.
| branch | Run 1 | Run 2 | Run 3 | Run 4 | Run 5 | Avg | SD |
|---|---|---|---|---|---|---|---|
| master | 9.17 | 9.16 | 9.11 | 9.18 | 9.28 | 9.18 | 0.06 |
| poll-timing | 18.47 | 20.79 | 24.66 | 14.69 | 19.65 | 19.21 | 3.36 |
I do have a few questions about seemingly important details that may be lost in their obscurity
benalleng
reviewed
Jun 19, 2026
Shared so all clients converge on one rate; a divergent rate is itself a fingerprint.
GET now peeks instead of blocking. The v2 waitmap it no longer uses is still woven into the Db trait, post_v2, and tests, so removal is a follow-up.
Contributor
Author
this now adds a small payjoin-core API, beyond original "core unchanged" scope discussed with @DanGould in #440 follow-ups (out of scope here):
makes sense to follow this approach? |
This was referenced Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes the
cadence + R_ipoll-timing leak in BIP77 v2the directory read each party's relay round-trip latency (R_i) from the regular poll interval, distinguishing sender from receiver. The client now polls on an independent Poisson schedule (the Loopix client-emission model), so the interval no longer carries R_i
the client can only own its cadence once the directory stops holding the GET, so
payjoin-mailroom(non-blocking GET) is the precondition forpayjoin-cli(Poisson polling). (split into separate PRs would busy-loop against a still-blocking directory)note: drops BIP 77's recommended 30s-blocking GET (should; 202/200 response codes unchanged).
part of #440
Disclosure: co-authored by Claude