Skip to content

fix(receipt): remove issued-on date from PDF receipt footer - #2958

Merged
innolope-dev merged 2 commits into
devfrom
fix/receipt-pdf-remove-issued-on
Sep 3, 2026
Merged

fix(receipt): remove issued-on date from PDF receipt footer#2958
innolope-dev merged 2 commits into
devfrom
fix/receipt-pdf-remove-issued-on

Conversation

@innolope-dev

Copy link
Copy Markdown
Collaborator

Summary

  • Removes the "Issued on" label/date row from the bottom of the downloadable PDF receipt footer
  • Drops the now-unused issuedOn/issuedOnLabel fields from ReceiptPdfModel and their construction

Test plan

  • npx jest src/app/receipt/[entryId]/pdf/__tests__/ — 29 tests pass
  • npx tsc --noEmit clean for the touched files

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 8df7fa7c-59e9-48f9-becb-c4d9c168de2d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
peanut-wallet Ready Ready Preview Sep 3, 2026 5:54pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 7062.75 → 7062.82 (+0.07)
Findings: 0 net (+5 new, -5 resolved)

🆕 New findings (5)

  • critical complexity — src/app/receipt/[entryId]/pdf/receipt-pdf-model.ts — CC 57, MI 47.82, SLOC 151
  • high method-complexity — src/app/receipt/[entryId]/pdf/receipt-pdf-model.ts:102 — buildReceiptPdfModel CC 40 SLOC 101
  • medium high-mdd — src/app/receipt/[entryId]/pdf/receipt-pdf-model.ts:102 — buildReceiptPdfModel: MDD 52.0 (uses across many lines from declarations)
  • medium complexity — src/app/receipt/[entryId]/pdf/ReceiptPdfDocument.tsx — CC 14, MI 52.06, SLOC 133
  • low high-dlt — src/app/receipt/[entryId]/pdf/receipt-pdf-model.ts:102 — buildReceiptPdfModel: DLT 20 (calls 20 distinct functions — high context load)

✅ Resolved (5)

  • src/app/receipt/[entryId]/pdf/receipt-pdf-model.ts — CC 57, MI 47.38, SLOC 156
  • src/app/receipt/[entryId]/pdf/receipt-pdf-model.ts:104 — buildReceiptPdfModel CC 40 SLOC 106
  • src/app/receipt/[entryId]/pdf/receipt-pdf-model.ts:104 — buildReceiptPdfModel: MDD 54.9 (uses across many lines from declarations)
  • src/app/receipt/[entryId]/pdf/ReceiptPdfDocument.tsx — CC 14, MI 51.97, SLOC 133
  • src/app/receipt/[entryId]/pdf/receipt-pdf-model.ts:104 — buildReceiptPdfModel: DLT 20 (calls 20 distinct functions — high context load)

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • unit: 5609 ran, 0 failed, 0 skipped, 1.5m

📊 Coverage (unit)

metric %
statements 74.0%
branches 59.4%
functions 67.5%
lines 74.9%
⏱ 10 slowest test cases
time test
🐢 9.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Network failure keeps loading while retries remain, then shows the generic error
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_MERCHANT_RECENT_REFUND fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_SOURCE_OVER_MONTHLY_CAP fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_MERCHANT_VOLUME_NEAR_CAP fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › a refused idempotency key tells the user to scan again, not to contact support
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_USER_NOT_PROVISIONED fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › routes the KYC rejection on its wire code, and does not retry it
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › User KYC not approved fails fast with copy that names the real cause
3.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Going offline blames the connection, and reconnecting clears it for the recovered scan
3.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Scan that recovers on the retry lands on the payment screen, not an error
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

@chip-peanut-bot chip-peanut-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chip review — no blocking findings — this is not an approval

Clean review. The PDF-only issue-date row and its model fields are removed consistently without changing the in-app receipt date.

Checked clean

  • Confirmed the detached worktree HEAD and merge base match the supplied exact head and base SHAs.
  • Traced ReceiptPdfModel construction through ReceiptPdfDocument and the public PDF route; no stale issuedOn field consumers remain.
  • Verified the shared issuedOn localization keys remain in use by the in-app receipt, so this PDF-only change does not orphan or remove required copy.
  • Reviewed correctness, security, adversarial failure scenarios, and slop across all four changed files; the diff is deletion-only and introduces no new trust boundary.
  • Exact-head unit, typecheck, eslint, format, analyze, and repository review checks passed. A focused local Jest run was unavailable because the detached worktree has no Jest executable.

Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.

Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.

Exact head: 17b691876f65 · Context: repo · Took 4m

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🖼 Visual diff — 1 screen moved

1 of 62 shots changed · 61 identical · baseline 367da93 → head ca475de

worst % screen widths
2.83% profile 320

job summary · before/after/diff images — artifact

Fixture screenshots, no backend. Advisory — this check never blocks a merge. Posted from the default branch by ds-shots-comment.yml; the report it renders is untrusted data.

@chip-peanut-bot chip-peanut-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chip review — no blocking findings — this is not an approval

Clean. The PDF footer no longer renders or constructs an issued-on field, while transaction lifecycle timestamps remain in the receipt rows.

Checked clean

  • Verified the detached worktree head, supplied base SHA, merge base, trusted author, base ref, and PR metadata all match the review request.
  • Correctness: traced ReceiptPdfModel construction through ReceiptPdfDocument and confirmed issuedOn/issuedOnLabel are removed together without removing transaction lifecycle date rows.
  • Regression and localization: checked the shared transaction-ID label change across en, es-419, and pt-BR catalogs and its in-app/PDF consumers; JSON catalogs parse successfully.
  • Security and privacy: the change adds no new input, authorization, data exposure, amount, workflow, or secret-handling surface.
  • Slop and tests: related model/render fixtures were updated and no dead references remain; focused tests could not start locally because ts-jest is absent from the detached worktree. At review time, typecheck, eslint, format, authorship, and approval checks passed while unit, ds-shots, native-export, analyze, and preview checks were still running.

Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.

Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.

Exact head: ca475de32882 · Context: repo · Took 5m

@innolope-dev
innolope-dev merged commit f05e3d2 into dev Sep 3, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant