fix(receipt): remove issued-on date from PDF receipt footer - #2958
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code-analysis diffPainscore total: 7062.75 → 7062.82 (+0.07) 🆕 New findings (5)
✅ Resolved (5)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
Clean review. The PDF-only issue-date row and its model fields are removed consistently without changing the in-app receipt date.
Checked clean
- Confirmed the detached worktree HEAD and merge base match the supplied exact head and base SHAs.
- Traced ReceiptPdfModel construction through ReceiptPdfDocument and the public PDF route; no stale issuedOn field consumers remain.
- Verified the shared issuedOn localization keys remain in use by the in-app receipt, so this PDF-only change does not orphan or remove required copy.
- Reviewed correctness, security, adversarial failure scenarios, and slop across all four changed files; the diff is deletion-only and introduces no new trust boundary.
- Exact-head unit, typecheck, eslint, format, analyze, and repository review checks passed. A focused local Jest run was unavailable because the detached worktree has no Jest executable.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Exact head: 17b691876f65 · Context: repo · Took 4m
🖼 Visual diff — 1 screen moved1 of 62 shots changed · 61 identical · baseline
job summary · before/after/diff images — artifact Fixture screenshots, no backend. Advisory — this check never blocks a merge. Posted from the default branch by ds-shots-comment.yml; the report it renders is untrusted data. |
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
Clean. The PDF footer no longer renders or constructs an issued-on field, while transaction lifecycle timestamps remain in the receipt rows.
Checked clean
- Verified the detached worktree head, supplied base SHA, merge base, trusted author, base ref, and PR metadata all match the review request.
- Correctness: traced ReceiptPdfModel construction through ReceiptPdfDocument and confirmed issuedOn/issuedOnLabel are removed together without removing transaction lifecycle date rows.
- Regression and localization: checked the shared transaction-ID label change across en, es-419, and pt-BR catalogs and its in-app/PDF consumers; JSON catalogs parse successfully.
- Security and privacy: the change adds no new input, authorization, data exposure, amount, workflow, or secret-handling surface.
- Slop and tests: related model/render fixtures were updated and no dead references remain; focused tests could not start locally because ts-jest is absent from the detached worktree. At review time, typecheck, eslint, format, authorship, and approval checks passed while unit, ds-shots, native-export, analyze, and preview checks were still running.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Exact head: ca475de32882 · Context: repo · Took 5m
Summary
issuedOn/issuedOnLabelfields fromReceiptPdfModeland their constructionTest plan
npx jest src/app/receipt/[entryId]/pdf/__tests__/— 29 tests passnpx tsc --noEmitclean for the touched files