Repository navigation
Conversation
Signed-off-by: Matthew Charles Busel <mattbusel@gmail.com>
Member
|
Please consult the
Additionally in this case, while this may be an issue, timer retries are not a solution, especially when the thing you are retrying can cost $/req (an associated Issue would've driven this out, which is why it is a requirement for first-time contributors). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetch_completioninagent/client/transport.rsturns any non-ok response into an error on the first try, so a single 429 or 503 from the provider ends the whole agent turn, andRetry-Afteris never read. This PR retries 429/500/502/503/504 up to three attempts with jittered backoff (honoring a delta-secondsRetry-Afterwhen the response exposes it, and giving up as before if it asks for more than 30s), waiting onset_timeoutso the Stop button still cancels. The policy comes fromllm-wasm(no I/O, builds for wasm32), pulled in only through the existingllm-agentfeature; 4xx errors like the 401 spec behave exactly as before.cargo clippy -p perspective-viewer --target wasm32-unknown-unknownis clean and prettier/rustfmt pass; I added a 503-then-200 case toagent_http.spec.tsnext to the 401 one but could not run the Playwright suite locally without the full emscripten build. I maintainllm-wasm(MIT) and will keep it current.